fix(openapi-react-query): propagate undefined errors from openapi-fetch#2813
Open
Will-hxw wants to merge 2 commits into
Open
fix(openapi-react-query): propagate undefined errors from openapi-fetch#2813Will-hxw wants to merge 2 commits into
Will-hxw wants to merge 2 commits into
Conversation
Use instead of truthiness check to properly handle cases where openapi-fetch returns for non-OK responses with empty bodies. Closes openapi-ts#2070
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: 19e40ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
No description provided. |
Author
|
Hi!@duncanbeevers,sorry to bother you. This PR has been open for a while, so I wanted to kindly check whether you might have time to review it or let me know if any changes are needed.I’m happy to make adjustments if required. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!response.okinstead oferrortruthiness check in queryFn, useInfiniteQuery, and useMutationerror: undefinedfor non-OK responses with empty bodiesWhy
When openapi-fetch receives a non-OK response (e.g., 500) with an empty body, it returns
{ error: undefined, response }. The previousif (error)check was falsy forundefined, causing the error to be silently swallowed. This fix checks!response.okinstead, ensuring errors are always propagated.Validation
pnpm test --filter openapi-react-query— all 38 tests pass (37 existing + 1 new)Related
Closes #2070