fix out of range in semi_sync_master_timeout#1207
Conversation
shlomi-noach
left a comment
There was a problem hiding this comment.
thank you, a couple changes requested
|
(you can see all CI jobs failed -- that's because of the |
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
left a comment
There was a problem hiding this comment.
we need to further change the matching go variable to int64 or uint64, correct? Let's do this in this PR, too
shlomi-noach
left a comment
There was a problem hiding this comment.
I think last requested changes
I didn't do |
Whoops. But I think we must use it, right? Because the value reported is |
|
I know why |
|
I wonder if we should literally first compare the string with |
!!! The name confused me, I assumed it returns a |
|
See #1209 |
|
|
Yeah, I'm 💯 👍 on that. |
Solves issue: #1205
Description
This PR sets
semi_sync_master_timeoutasbigintto avoid out of range (overflow) errors.