Replace Tart VM infrastructure with direct macOS host testing#26
Merged
fullstackjam merged 1 commit intomainfrom Apr 19, 2026
Merged
Conversation
|
👋 Thanks for opening this pull request! Before merging:
@fullstackjam will review this soon. Thanks for contributing! 🚀 |
Cirrus CI was gated on `only_if: $CIRRUS_CRON` and the repo has no paid credits, so the ~900 lines of Tart-based L5 tests have never run. Replace the VM wrapper with a MacHost helper that exec's directly against the host, and trigger it from the free GitHub Actions macos-latest runner on release tags / workflow_dispatch. - testutil/tartvm.go -> testutil/machost.go: drop SSH/scp/expect-over-SSH and the tart clone/boot/destroy lifecycle; require CI=true or OPENBOOT_E2E_DESTRUCTIVE=1 to activate so local `go test -tags=e2e,vm` is a no-op rather than a foot-gun. - test/e2e/: rename TartVM -> MacHost across call sites; relax bare-system assumptions that no longer hold on a GH runner (brew is preinstalled, common CLI tools may be); make vmInstallHomebrew idempotent. - Drop .cirrus.yml; add macos-e2e workflow job gated on release tags / workflow_dispatch. - Makefile: trim the test-vm-release -run regex to tests that actually exist; reword comments to reflect destructive-host semantics. - CLAUDE.md / CONTRIBUTING.md: update L5 references. https://claude.ai/code/session_01Dg8nibLFZGKmeYgfUBQrsA
fullstackjam
force-pushed
the
claude/review-e2e-testing-strategy-0qfh3
branch
from
2adf8c0 to
6221b18
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the Tart-based VM testing infrastructure with direct execution on ephemeral macOS hosts (GitHub Actions runners). Removes 298 lines of SSH/VM orchestration code and replaces it with a simpler 126-line
MacHosthelper that runs commands directly on the current system.Why?
The Tart VM approach had several limitations:
GitHub Actions
macos-latestrunners are ephemeral and can be safely destroyed after tests, making them ideal for destructive E2E tests. This change:The new
MacHosthelper provides the same API as the oldTartVM(Run, RunWithEnv, RunInteractive, CopyFile, Destroy) but operates directly on the host. Tests are protected by environment checks (CI=trueorOPENBOOT_E2E_DESTRUCTIVE=1) to prevent accidental execution on developer machines.Testing
NewMacHost()instead ofNewTartVM()vmInstallHomebrew,vmCopyDevBinary, etc.) updated to work with the new interfaceTestVM_Infrasimplified to validate host readiness instead of VM infrastructuremacos-e2ejob that runs on release tagsNotes for reviewer
MacHostAPI is intentionally compatible with the oldTartVMinterface to minimize test changesvmInstallHomebrew()now skips installation if Homebrew is already present (GitHub Actions runners ship with it)OPENBOOT_E2E_DESTRUCTIVE=1is setexpect(1)integration for interactive tests is preserved and works identicallyhttps://claude.ai/code/session_01Dg8nibLFZGKmeYgfUBQrsA