refactor: remove unused exported symbols from internal packages#33
Merged
fullstackjam merged 1 commit intomainfrom Apr 19, 2026
Merged
Conversation
- brew: delete GetInstalledLeaves and GetInstalledTaps (never called outside tests; snapshot capture uses GetInstalledPackages instead) - system: delete Architecture, HomebrewPrefix, IsHomebrewInstalled, IsXcodeCliInstalled, IsGumInstalled, and InstallHomebrew — none are referenced by any production call site; clean up the five imports (crypto/sha256, encoding/hex, io, net/http, httputil) that existed only to support InstallHomebrew - npm: unexport GetNodeVersion → getNodeVersion; it is only ever called by the package-internal warnIfNodeVersionTooLow helper - ui: delete empty ui_test.go (contained only the package declaration) https://claude.ai/code/session_01R5q9fGs8dJR7uD5xaxCutN
|
👋 Thanks for opening this pull request! Before merging:
@fullstackjam will review this soon. Thanks for contributing! 🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
outside tests; snapshot capture uses GetInstalledPackages instead)
IsXcodeCliInstalled, IsGumInstalled, and InstallHomebrew — none are
referenced by any production call site; clean up the five imports
(crypto/sha256, encoding/hex, io, net/http, httputil) that existed
only to support InstallHomebrew
by the package-internal warnIfNodeVersionTooLow helper
https://claude.ai/code/session_01R5q9fGs8dJR7uD5xaxCutN