Fix warning wrongly appearing on template change#1584
Open
Arnei wants to merge 1 commit intoopencast:r/19.xfrom
Open
Fix warning wrongly appearing on template change#1584Arnei wants to merge 1 commit intoopencast:r/19.xfrom
Arnei wants to merge 1 commit intoopencast:r/19.xfrom
Conversation
When changing the template in the acl tab, if the current acl settings were invalid, a warning would appear *after* the template change about how the acl was invalid, when due to the template change it actually no longer wasn't. This fixes that.
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Contributor
|
This pull request is deployed at test.admin-interface.opencast.org/1584/2026-04-23_08-42-31/ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When changing the template in the acl tab, if the current acl settings were invalid, a warning would appear after the template change about how the acl was invalid, when due to the template change it actually no longer wasn't.
This fixes that.
How to test this
Get your ACL to be invalid (by removing all roles, or by adding a new role and not selecting a role in the dropdown). Then change template.