Conversation
|
This pull request is deployed at test.editor.opencast.org/1585/2025-05-20_13-46-20/ . |
|
Seems like there are issues with Safari. |
|
Safari issue should now be fixed. |
|
This pull request is deployed at test.editor.opencast.org/1585/2025-06-11_08-59-03/ . |
|
Is this the expected behaviour? Screencast.from.2025-06-17.22-48-55.mp4I feel like it's supposed to zoom in more? |
|
That is not expected behaviour, it should roughly double in size. What browser are you testing with? |
Adds "fullscreen" buttons to the videos in the cutting tab. The goal is to give users a simple way to zoom in on a video in case they need to perceive details, like for example small text on a blackboard. TODO: Fullscreen button positioning
This was written by @ferishili, many thanks! Fixes an issue where the video players would not show up IN SAFARI, leaving small empty boxes in their place. Only after clicking the full screen button a few times would the videos then show up. This fixes the issue by toggling the fullscreen button ourselves via code. We also confine this toggling to Safari, so that people who use reasonable browsers are not affected by any brief visual glitches this may result in.
|
This pull request is deployed at test.editor.opencast.org/1585/2026-04-20_12-45-56/ . |
|
Still seeing the same behaviour I was seeing before the repoint. Testing with Chrome, though I see it in firefox as well. |
ferishili
left a comment
There was a problem hiding this comment.
Thanks @Arnei!
I tested this on the three major browsers on macOS (Safari 26.4, Firefox 149.0.2, and Chrome 147.0.7727.56), and it works great. ✅
One small improvement that would be nice to add: cursor: pointer; for the new button.
Also, there's an accessibility (A11y) aspect to consider for the new button. I'm not sure yet how far we want to go with that here, but it might be worth taking a quick look and try to introduce it on new elements.
|
Hi @ferishili , thanks for testing! I added |
|
Great, |
Also changed the icon to better reflect state.
|
Nice! Kudos for the awesome icons 👍✨ |

Adds "fullscreen" buttons to the videos in the cutting tab.
The goal is to give users a simple way to zoom in on a video in case they need to perceive details, like for example small text on a blackboard.