Merged
Conversation
|
This pull request is deployed at test.editor.opencast.org/1677/2026-04-20_11-37-07/ . |
github-actions
Bot
added
the
status:conflicts
|
This pull request has conflicts ☹ |
Arnei
force-pushed
the
configurable-hotkeys
branch
from
a1b0d4c to
6de7cd5
Compare
github-actions
Bot
added
status:conflicts
|
This pull request has conflicts ☹ |
Arnei
force-pushed
the
configurable-hotkeys
branch
from
6de7cd5 to
f9e9dcd
Compare
github-actions
Bot
removed
the
status:conflicts
ferishili
reviewed
Apr 15, 2026
ferishili
reviewed
Apr 15, 2026
ferishili
suggested changes
Apr 15, 2026
Contributor
ferishili
left a comment
ferishili
left a comment
There was a problem hiding this comment.
Thanks @Arnei,
Here are a few points I'd like to highlight after testing the current behavior:
-
Saving without a key combination clears the entry silently
- Right now, saving without entering a key combination results in an empty value being saved.
- At minimum, the UI should notify the user that the existing shortcut is being removed.
- Ideally, saving an empty value should be prevented entirely, and instead a dedicated Delete option should be provided (either inside the modal or, even better, next to the edit button with a confirmation step).
-
Empty key combinations are displayed as a small gray square
- When an entry has no assigned key combination, the UI currently shows a small gray square.
- It would be clearer to display a label such as "Not defined" or "No combination" instead.
-
Duplicate key combinations are currently allowed
- At the moment, it's possible to assign the same shortcut (e.g.,
ArrowLeft) to multiple entries. - The system should detect duplicates and notify the user.
- Ideally, the UI should offer the option to replace the existing assignment with confirmation.
- At the moment, it's possible to assign the same shortcut (e.g.,
-
resetHotkeyandresetAllHotkeysreducers delete instead of reset- The reducers
resetHotkeyandresetAllHotkeysinsrc/redux/hotkeySlice.tscurrently remove values instead of restoring defaults, and they are not being used. - It would be better if these reducers restored the default key combinations instead.
- I'd also suggest adding "Reset to default" (per entry) and "Reset all to default" actions on the keyboard controls page.
- The reducers
Arnei
force-pushed
the
configurable-hotkeys
branch
from
f9e9dcd to
8e62469
Compare
github-actions
Bot
added
the
status:conflicts
|
This pull request has conflicts ☹ |
Member
Author
|
Thanks for the nice suggestions. I hope I managed to address them reasonably well. |
Allows users to configure their own hotkeys. This should empower users to choose the hotkeys that work for them, instead of having to use the cumbersome "Shift + Alt + something" combinations. Configured hotkeys are persisted in local storage. To that end, this patch introduces the redux-persist package and all the necessary boilerplate that it requires. This also makes more changes to KeyboardControls.tsx than strictly necessary in the hopes of making it a little less complicated.
With this changed the key recorder or hotkeys should listen for the produced key, better supporting alternative keyboards.
Setting a hotkey to nothing was possibly before, but felt very unintentional as the user had to save an empty hotkey sequence. This prevents users from saving empty hotkeys sequences, and instead gives them an explicit button for unsetting.
Do not allow a user to set a hotkey if that hotkey already exists. Disables in the save button in such a case and shows a warning message.
To allow user to reset a hotkey to its default sequence(s).
We use "+" for delimiting purposes, so it would be problematic if user included that in their hotkeys sequence.
Arnei
force-pushed
the
configurable-hotkeys
branch
from
92bc136 to
151b125
Compare
github-actions
Bot
removed
the
status:conflicts
Contributor
|
Thanks @arne, However, there are still a couple of small things left to address:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to configure their own hotkeys.
This should empower users to choose the hotkeys that work for them, instead of having to use the cumbersome "Shift + Alt + something" combinations.
Configured hotkeys are persisted in local storage. To that end, this patch introduces the redux-persist package and all the necessary boilerplate that it requires.
This also makes more changes to KeyboardControls.tsx than strictly necessary in the hopes of making it a little less complicated.