Skip to content

Overhaul thumbnail view #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arnei wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Overhaul thumbnail view #1663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/i18n/locales/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,10 @@
"title": "Thumbnail Editor",
"noThumbnailAvailable": "No Thumbnail available",
"previewImageAlt": "Thumbnail for track",
"buttonGenerate": "Generate",
"buttonGenerate": "Generate from frame",
"buttonGenerate-tooltip": "Generate a new thumbnail from the current timeline marker position",
"buttonGenerate-tooltip-aria": "Generate a new thumbnail from the current timeline marker position",
"buttonUpload": "Upload",
"buttonUpload": "Upload image",
"buttonUpload-tooltip": "Upload an image",
"buttonUpload-tooltip-aria": "Upload an image",
"buttonUseForOtherThumbnails": "Use for all tracks",
Expand All @@ -218,7 +218,9 @@
"buttonGenerateAll-tooltip-aria": "Generate new thumbnails for all tracks from the current timeline marker position",
"explanation": "Upload or generate a thumbnail for each track.",
"primary": "Primary",
"secondary": "Secondary"
"secondary": "Secondary",
"backButton": "Back",
"backButton-tooltip": "Return to thumbnail selection"
},

"thumbnailSimple": {
Expand Down
4 changes: 4 additions & 0 deletions src/main/MainMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import { setIsPlaying } from "../redux/videoSlice";
import { useTranslation } from "react-i18next";
import { resetPostRequestState } from "../redux/workflowPostSlice";
import { setIsDisplayEditView } from "../redux/subtitleSlice";
import { setIsDisplayEditView as setIsDisplayEditViewThumbnail } from "../redux/thumbnailSlice";

import { useTheme } from "../themes";
import { ProtoButton } from "@opencast/appkit";
Expand Down Expand Up @@ -133,6 +134,9 @@ export const MainMenuButton: React.FC<mainMenuButtonInterface> = ({
if (stateName === MainMenuStateNames.subtitles) {
dispatch(setIsDisplayEditView(false));
}
if (stateName === MainMenuStateNames.thumbnail) {
dispatch(setIsDisplayEditViewThumbnail(false));
}
// Halt ongoing events
dispatch(setIsPlaying(false));
// Reset states
Expand Down
Loading
Loading