Skip to content

feat: editor comment support#7452

Open
Bennit99 wants to merge 3 commits intoopencast:developfrom
Bennit99:develop
Open

feat: editor comment support#7452
Bennit99 wants to merge 3 commits intoopencast:developfrom
Bennit99:develop

Conversation

@Bennit99
Copy link
Copy Markdown

@Bennit99 Bennit99 commented Mar 3, 2026 •
edited
Loading

Add full comment and reply support to the Opencast video editor, matching the functionality available in the Admin UI.

  • Add comment and reply processing in editor endpoint edit.json (create, update, delete for both comments and replies)
  • Read commen Reasons from list provider at etc/listproviders/event.comment.reasons.properties
  • Roadmap issue

How to test this patch

  • For testing the endpoint, use the Editor UI and create and delete some comments and replies
  • editor PR

Your pull request should…

@Bennit99
Add full comment and reply support to the Opencast video editor, matc…
801f941 
…hing the functionality available in the Admin UI.

- Add comment and reply processing in editor POST endpoint edit.json (create, update, delete for both comments and replies)
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026 •
edited by gregorydlogan
Loading

Hi @Bennit99
Thank you for contributing to Opencast.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

Form submitted - G

@Bennit99 Bennit99 mentioned this pull request Mar 3, 2026
Open
@gregorydlogan
Copy link
Copy Markdown
Member

gregorydlogan commented Mar 5, 2026

For those curious, I have confirmed that this is a student at Munster.

@Bennit99 did you fill out the ICLA form? Apereo can take quite some time to process them.

@Bennit99
Copy link
Copy Markdown
Author

Bennit99 commented Mar 5, 2026

Yes, I filled out the ICLA online form.

mtneug
mtneug requested changes Mar 20, 2026
View reviewed changes
Comment thread docs/guides/admin/docs/configuration/videoeditor.frontend.md Outdated
Comment thread docs/guides/admin/docs/configuration/videoeditor.frontend.md Outdated
Comment thread modules/editor-service/src/main/java/org/opencastproject/editor/EditorServiceImpl.java Outdated
Comment thread modules/editor-service/src/main/java/org/opencastproject/editor/EditorServiceImpl.java Outdated
Comment thread modules/editor-service/src/main/java/org/opencastproject/editor/EditorServiceImpl.java
Comment thread modules/editor-service/src/main/java/org/opencastproject/editor/EditorServiceImpl.java
@mtneug mtneug requested review from mtneug March 20, 2026 10:01
@mtneug
Copy link
Copy Markdown
Member

mtneug commented Mar 20, 2026

I now also tested this with the frontend part. Works as expected.

@Bennit99
resolve review comments
73e4246 
add displayName (from User.getName) to comments and ommentReply,
use orElseThrow instead of orElse(0L) for getting comments,
revert prettier fromatting changes
Arnei
Arnei approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets a +1 from me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arnei Arnei Arnei approved these changes

@mtneug mtneug Awaiting requested review from mtneug

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Bennit99 @gregorydlogan @mtneug @Arnei