fix: add componentrelease delete permission#501
Conversation
Co-authored-by: Codex <codex@openai.com> Signed-off-by: prdai <prdai@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
binoyPeries
left a comment
There was a problem hiding this comment.
Hi @prdai , thank you for the PR. However, this should first be rectified in the main OC repo https://github.com/openchoreo/openchoreo/tree/release-v1.0.
Hint: we need to update the action registry to make this work. After doing that, please reevaluate the current PR that you have opened. Hope this helps :)
Summary
openchoreo.release.deletetocomponentrelease:deletecomponentrelease:deletein the default role templatesTesting
yarn prettier --check plugins/openchoreo-common/src/index.ts plugins/openchoreo-common/src/permissions.ts plugins/openchoreo/src/components/AccessControl/RolesTab/RoleDialog.tsxyarn tscyarn workspace @openchoreo/backstage-plugin-common buildyarn workspace @openchoreo/backstage-plugin buildcomponentrelease:deleteNotes
Related to openchoreo/openchoreo#3061.
AI assistance was used while preparing this change; the patch was manually reviewed and re-verified multiple times before submission.