Skip to content

feat: rename aws logs module#120

Merged
chalindukodikara merged 1 commit into
openchoreo:mainfrom
chalindukodikara:issue-3149_rename_logs_module
May 18, 2026
Merged

feat: rename aws logs module#120
chalindukodikara merged 1 commit into
openchoreo:mainfrom
chalindukodikara:issue-3149_rename_logs_module

Conversation

@chalindukodikara
Copy link
Copy Markdown
Contributor

@chalindukodikara chalindukodikara commented May 18, 2026

Purpose

$subject

Approach

Summarize the solution and implementation details.

Related Issues

openchoreo/openchoreo#3298

Checklist

  • Tests added or updated (unit, integration, etc.)
  • Samples updated (if applicable)

Remarks

Add any additional context, known issues, or TODOs related to this PR.

Summary by CodeRabbit

Release Notes

  • Documentation

    • Updated installation, troubleshooting, and testing instructions to reflect new resource naming and identifier changes
  • Chores

    • Renamed Helm chart release from observability-logs-cloudwatch to observability-logs-aws-cloudwatch
    • Updated all Kubernetes resource identifiers including deployments, services, service accounts, network policies, and webhook routes
    • Updated internal module paths and configuration references accordingly

Review Change Stack

Signed-off-by: Chalindu Kodikara <chalindumkodikara@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: abfd274c-1a29-4a9c-8c07-ca0fb5a2d341

📥 Commits

Reviewing files that changed from the base of the PR and between e3bef8c and 5097062.

⛔ Files ignored due to path filters (4)
  • observability-logs-aws-cloudwatch/go.sum is excluded by !**/*.sum
  • observability-logs-aws-cloudwatch/helm/Chart.lock is excluded by !**/*.lock
  • observability-logs-aws-cloudwatch/internal/api/gen/models.gen.go is excluded by !**/gen/**
  • observability-logs-aws-cloudwatch/internal/api/gen/server.gen.go is excluded by !**/gen/**
📒 Files selected for processing (51)
  • observability-logs-aws-cloudwatch/.dockerignore
  • observability-logs-aws-cloudwatch/Dockerfile
  • observability-logs-aws-cloudwatch/Makefile
  • observability-logs-aws-cloudwatch/README.md
  • observability-logs-aws-cloudwatch/go.mod
  • observability-logs-aws-cloudwatch/helm/.helmignore
  • observability-logs-aws-cloudwatch/helm/Chart.yaml
  • observability-logs-aws-cloudwatch/helm/templates/_helpers.tpl
  • observability-logs-aws-cloudwatch/helm/templates/adapter/configmap.yaml
  • observability-logs-aws-cloudwatch/helm/templates/adapter/deployment.yaml
  • observability-logs-aws-cloudwatch/helm/templates/adapter/httproute.yaml
  • observability-logs-aws-cloudwatch/helm/templates/adapter/networkpolicy.yaml
  • observability-logs-aws-cloudwatch/helm/templates/adapter/service.yaml
  • observability-logs-aws-cloudwatch/helm/templates/adapter/serviceaccount.yaml
  • observability-logs-aws-cloudwatch/helm/templates/adapter/webhook-secret.yaml
  • observability-logs-aws-cloudwatch/helm/templates/aws-credentials/secret.yaml
  • observability-logs-aws-cloudwatch/helm/templates/cloudwatch-agent/post-install-hook.yaml
  • observability-logs-aws-cloudwatch/helm/templates/cloudwatch-setup/job.yaml
  • observability-logs-aws-cloudwatch/helm/templates/cloudwatch-setup/serviceaccount.yaml
  • observability-logs-aws-cloudwatch/helm/templates/validate.yaml
  • observability-logs-aws-cloudwatch/helm/values.yaml
  • observability-logs-aws-cloudwatch/init/Dockerfile
  • observability-logs-aws-cloudwatch/init/setup-cloudwatch.sh
  • observability-logs-aws-cloudwatch/internal/api/cfg-models.yaml
  • observability-logs-aws-cloudwatch/internal/api/cfg-server.yaml
  • observability-logs-aws-cloudwatch/internal/auth/webhook.go
  • observability-logs-aws-cloudwatch/internal/auth/webhook_test.go
  • observability-logs-aws-cloudwatch/internal/cloudwatch/alert_patterns.go
  • observability-logs-aws-cloudwatch/internal/cloudwatch/alert_patterns_test.go
  • observability-logs-aws-cloudwatch/internal/cloudwatch/alerts.go
  • observability-logs-aws-cloudwatch/internal/cloudwatch/alerts_crud.go
  • observability-logs-aws-cloudwatch/internal/cloudwatch/alerts_crud_test.go
  • observability-logs-aws-cloudwatch/internal/cloudwatch/alerts_test.go
  • observability-logs-aws-cloudwatch/internal/cloudwatch/client.go
  • observability-logs-aws-cloudwatch/internal/cloudwatch/client_test.go
  • observability-logs-aws-cloudwatch/internal/cloudwatch/queries.go
  • observability-logs-aws-cloudwatch/internal/cloudwatch/queries_test.go
  • observability-logs-aws-cloudwatch/internal/cloudwatch/sns_verify.go
  • observability-logs-aws-cloudwatch/internal/cloudwatch/sns_verify_test.go
  • observability-logs-aws-cloudwatch/internal/cloudwatch/webhook.go
  • observability-logs-aws-cloudwatch/internal/cloudwatch/webhook_test.go
  • observability-logs-aws-cloudwatch/internal/config.go
  • observability-logs-aws-cloudwatch/internal/config_test.go
  • observability-logs-aws-cloudwatch/internal/handlers.go
  • observability-logs-aws-cloudwatch/internal/handlers_test.go
  • observability-logs-aws-cloudwatch/internal/observer/client.go
  • observability-logs-aws-cloudwatch/internal/observer/client_test.go
  • observability-logs-aws-cloudwatch/internal/server.go
  • observability-logs-aws-cloudwatch/internal/server_test.go
  • observability-logs-aws-cloudwatch/main.go
  • observability-logs-aws-cloudwatch/module.yaml

📝 Walkthrough

Walkthrough

This pull request consistently renames the observability logs CloudWatch adapter module and Helm chart from observability-logs-cloudwatch to observability-logs-aws-cloudwatch. The rename propagates through the Go module path, Helm chart metadata, Kubernetes resource identifiers, application imports, and documentation.

Changes

Module and Helm chart rename to AWS CloudWatch variant

Layer / File(s) Summary
Module path and chart metadata
go.mod, Chart.yaml, module.yaml
Go module path, Helm chart name, and Docker image entry updated to observability-logs-aws-cloudwatch.
Helm template helpers and webhook secret logic
helm/templates/_helpers.tpl
Helm named templates renamed from logs-cloudwatch.* to logs-aws-cloudwatch.* (logGroupPrefix, region, logGroupName, validate, webhookSecretName); fallback webhook secret name updated to logs-adapter-aws-cloudwatch-webhook-token.
Helm adapter deployment and core resources
helm/templates/adapter/deployment.yaml, helm/templates/adapter/configmap.yaml, helm/templates/adapter/webhook-secret.yaml
Deployment, ConfigMap, and webhook Secret use AWS-specific adapter name and renamed helpers. Pod serviceAccountName, container name, and configMapRef aligned to logs-adapter-aws-cloudwatch.
Kubernetes networking and setup resources
helm/templates/adapter/service.yaml, helm/templates/adapter/serviceaccount.yaml, helm/templates/adapter/httproute.yaml, helm/templates/adapter/networkpolicy.yaml, helm/templates/aws-credentials/secret.yaml, helm/templates/cloudwatch-agent/post-install-hook.yaml, helm/templates/cloudwatch-setup/job.yaml, helm/templates/validate.yaml
Service, ServiceAccount, HTTPRoute, NetworkPolicy, AWS credentials Secret, post-install hook Job, setup Job, and validation template updated with AWS CloudWatch-specific resource names and helper template references.
Helm values configuration
helm/values.yaml
Fluent Bit override comments and image repository field references updated to use aws-cloudwatch naming.
Application code imports and constants
main.go, internal/server.go, internal/handlers.go, internal/handlers_test.go, internal/auth/webhook.go, internal/auth/webhook_test.go, internal/cloudwatch/alerts.go
Go application and test files import packages from observability-logs-aws-cloudwatch module. TagManagedByValue constant updated to "observability-logs-aws-cloudwatch".
Installation and troubleshooting documentation
README.md
Helm release name, ServiceAccount name, and deployment references updated to observability-logs-aws-cloudwatch across EKS, non-EKS, single-cluster, observability-plane, and data-plane installation sections; troubleshooting and test commands updated to reference renamed adapter deployment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • openchoreo/community-modules#110: Modifies the same CloudWatch Helm helper templates (_helpers.tpl), with changes to named helpers for multi-cluster log configuration logic that interact with the AWS-specific rename in this PR.

Suggested reviewers

  • akila-i
  • nilushancosta
  • LakshanSS

🐰 A module renamed with pride and care,
From logs-cloudwatch to AWS fair,
Helm charts and helpers aligned anew,
In every template, docs, and view.
The adapter stands ready, now bearing its cloud-bright name! ☁️

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. Purpose section contains only '$subject' placeholder, and Approach, Related Issues, and Remarks sections contain only template placeholders without actual implementation details. Fill in the Purpose section with actual problem/need description, provide Approach details explaining the renaming scope and strategy, reference any related issues, and add relevant remarks about the changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: rename aws logs module' clearly and specifically describes the main change: renaming the AWS CloudWatch logs module throughout the codebase.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chalindukodikara chalindukodikara merged commit b67eb70 into openchoreo:main May 18, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants