fix: fix build logs in aws logs module#122
Conversation
Signed-off-by: Chalindu Kodikara <chalindumkodikara@gmail.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR enhances the AWS CloudWatch observability module to version 0.2.1 by improving log extraction from Fluent Bit messages, refactoring workflow query logic away from annotations, and adding detailed AWS CLI setup documentation for Pod Identity and EventBridge integration. ChangesAWS CloudWatch Observability Module v0.2.1
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@observability-logs-aws-cloudwatch/internal/cloudwatch/queries.go`:
- Around line 131-134: The pod-name filter built in queries.go currently uses
fmt.Fprintf with escapeInsightsRegex(p.WorkflowRunName) to match any pod_name
prefix, which can overmatch (e.g., my-build-01 vs my-build-010); update the
regex passed to fmt.Fprintf in the same block to add a boundary so only the
exact run name or that run name followed by a hyphen is matched (use the escaped
WorkflowRunName from escapeInsightsRegex and append a regex fragment that
enforces either a hyphen or end-of-string, e.g., .../^%s(-|$)/) so
kubernetes.pod_name matches only the intended workflow run pods.
In `@observability-logs-aws-cloudwatch/README.md`:
- Around line 352-354: The README currently directs creating a customer-managed
IAM policy named OpenChoreoCloudWatchLogsAdapterPolicy which will fail with
EntityAlreadyExists if run twice; update the docs or commands so they are
idempotent by checking for an existing policy before creating it (e.g., query
for a policy with name OpenChoreoCloudWatchLogsAdapterPolicy and skip/create
only if absent) or add a clear note that the policy name must be unique per
account and recommend using a custom name or conditional creation; refer to the
policy name OpenChoreoCloudWatchLogsAdapterPolicy in the README and ensure the
same change is applied to the other occurrence later in the file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1dbccafa-00e0-44d6-be88-8adcd377203e
📒 Files selected for processing (6)
observability-logs-aws-cloudwatch/README.mdobservability-logs-aws-cloudwatch/helm/Chart.yamlobservability-logs-aws-cloudwatch/internal/cloudwatch/client.goobservability-logs-aws-cloudwatch/internal/cloudwatch/client_test.goobservability-logs-aws-cloudwatch/internal/cloudwatch/queries.goobservability-logs-aws-cloudwatch/internal/cloudwatch/queries_test.go
Signed-off-by: Chalindu Kodikara <chalindumkodikara@gmail.com>
Signed-off-by: Chalindu Kodikara <chalindumkodikara@gmail.com>
Signed-off-by: Chalindu Kodikara <chalindumkodikara@gmail.com>
Purpose
$subject
Approach
Related Issues
openchoreo/openchoreo#3298
Checklist
Remarks
Summary by CodeRabbit
Documentation
Bug Fixes
Chores