docs: move secret reference writes to the pe toolset#622
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR contains two independent changes: the Plugin category field is made optional across the marketplace type system and ecosystem pages to support plugins without categorization, and MCP Servers reference documentation is reorganized to clarify secret reference tool distribution across Control Plane toolsets. ChangesPlugin Category Optional Migration
MCP Servers Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/reference/mcp-servers.mdx (1)
71-71: 💤 Low valueConsider simplifying the cross-reference phrasing.
The phrase "(PE toolset; enable PE alongside Namespace)" is slightly awkward. Consider replacing with "(available in the PE toolset)" for better readability, since the broader context already mentions toolset combination in the tip at line 328.
✨ Suggested rewording
-- `get_secret_reference` ‡ — Get a single secret reference's full spec (template, data sources, refresh interval, target plane). For sync status, query `get_resource_events` (PE toolset; enable PE alongside Namespace) against the rendered ExternalSecret on the data plane +- `get_secret_reference` ‡ — Get a single secret reference's full spec (template, data sources, refresh interval, target plane). For sync status, query `get_resource_events` (available in the PE toolset) against the rendered ExternalSecret on the data plane🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/reference/mcp-servers.mdx` at line 71, Replace the awkward parenthetical "(PE toolset; enable PE alongside Namespace)" with a simpler phrase; update the sentence referencing get_secret_reference and get_resource_events so it reads that sync status can be queried via get_resource_events against the rendered ExternalSecret on the data plane and clarify the tool availability by using "(available in the PE toolset)" (keep mentions of get_secret_reference, get_resource_events, ExternalSecret, Namespace and PE intact for context).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/reference/mcp-servers.mdx`:
- Line 71: Replace the awkward parenthetical "(PE toolset; enable PE alongside
Namespace)" with a simpler phrase; update the sentence referencing
get_secret_reference and get_resource_events so it reads that sync status can be
queried via get_resource_events against the rendered ExternalSecret on the data
plane and clarify the tool availability by using "(available in the PE toolset)"
(keep mentions of get_secret_reference, get_resource_events, ExternalSecret,
Namespace and PE intact for context).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 96139257-4b66-4c37-9aac-4aee62f2b294
📒 Files selected for processing (5)
docs/reference/mcp-servers.mdxsrc/components/PluginCard/PluginCard.tsxsrc/data/marketplace-plugins.jsonsrc/pages/ecosystem.tsxsrc/pages/ecosystem/item.tsx
The control-plane MCP server now registers create_, update_, and delete_secret_reference on the pe toolset only; list_secret_references and get_secret_reference are dual-registered on both the namespace and pe toolsets so developers can inspect what's available without enabling pe. Reflects openchoreo/openchoreo#3504. Signed-off-by: Rashad Sirajudeen <rashad@wso2.com>
Per coderabbit review on openchoreo#622: replace "(PE toolset; enable PE alongside Namespace)" with "(available in the PE toolset)" — cleaner phrasing, same meaning. Signed-off-by: Rashad Sirajudeen <rashad@wso2.com>
Signed-off-by: Rashad Sirajudeen <rashad@wso2.com>
2 participants
Purpose
Reflects the toolset-membership change in openchoreo/openchoreo#3504. SecretReference writes are now pe-only; reads stay dual-registered on namespace and pe so developers can list and inspect references without enabling pe.
Approach
create_/update_/delete_secret_referencefrom the Namespace Toolset section indocs/reference/mcp-servers.mdx.list_secret_references/get_secret_referencewith ‡ and footnote the dual registration in both sections.Checklist
Remarks