Skip to content

chore: harden CI workflows and clear lint debt #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steipete merged 4 commits into from
May 9, 2026
Merged

chore: harden CI workflows and clear lint debt #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd5e884
ci: add timeout-minutes to disabled-target echo jobs
May 8, 2026
7606340
ci: add concurrency groups to write-side repair workflows
May 8, 2026
c5fc7be
Merge remote-tracking branch 'origin/main' into ted/clawsweeper-harde…
steipete May 9, 2026
4237d2f
docs: credit workflow hardening
steipete May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/commit-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ jobs:
name: Skip disabled target commit review
if: ${{ github.event_name == 'repository_dispatch' && github.event.client_payload.target_repo == 'openclaw/clawhub' && vars.CLAWSWEEPER_ENABLE_CLAWHUB != '1' }}
runs-on: ubuntu-latest
timeout-minutes: 5
Copy link
Copy Markdown
Contributor

@steipete steipete May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is very tight

steps:
- name: Explain skipped commit review
run: |
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/repair-comment-router.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
CLAWSWEEPER_APP_CLIENT_ID: Iv23liOECG0slfuhz093

concurrency:
group: repair-comment-router-${{ github.event.inputs.target_repo || github.event.client_payload.target_repo || 'openclaw/openclaw' }}
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include scheduled target repo in concurrency key

Update the workflow-level concurrency group to include the same schedule-time target resolution used by the router step. Right now the group only checks github.event.inputs.target_repo and github.event.client_payload.target_repo, then falls back to 'openclaw/openclaw', but scheduled runs actually use vars.CLAWSWEEPER_TARGET_REPO when choosing --repo in the routing step. If that variable is set to a non-default repo, those runs are still placed in the openclaw/openclaw concurrency group, so unrelated target repos can block/cancel each other under concurrency limits and drop routing cycles.

Useful? React with 👍 / 👎.

cancel-in-progress: false
Comment on lines +71 to +73
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve all pending comment-router runs in concurrency queue

This new top-level concurrency block can drop repository_dispatch events under load because GitHub Actions defaults concurrency queues to single pending run: when a second pending run arrives, the older pending run is canceled and replaced even with cancel-in-progress: false. In this workflow, that means if one run is active and multiple comment dispatches arrive, intermediate comment-router runs can be discarded, so some commands may never be routed (especially when schedule-based execute is disabled). Add queue: max (or another explicit queue strategy) to avoid losing queued events.

Useful? React with 👍 / 👎.


jobs:
route-comments:
runs-on: ubuntu-latest
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/repair-commit-finding-intake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ jobs:
name: Skip disabled target commit finding
if: ${{ github.event_name == 'repository_dispatch' && github.event.client_payload.target_repo == 'openclaw/clawhub' && vars.CLAWSWEEPER_ENABLE_CLAWHUB != '1' }}
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- name: Explain skipped commit finding
run: |
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/repair-finalize-open-prs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
CLAWSWEEPER_APP_CLIENT_ID: Iv23liOECG0slfuhz093

concurrency:
group: clawsweeper-repair-finalize-open-prs
cancel-in-progress: false

jobs:
finalize:
runs-on: ${{ inputs.runner }}
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/repair-self-heal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
CLAWSWEEPER_APP_CLIENT_ID: Iv23liOECG0slfuhz093

concurrency:
group: clawsweeper-repair-self-heal
cancel-in-progress: false

jobs:
self-heal:
runs-on: ${{ github.event_name == 'workflow_dispatch' && inputs.runner || vars.CLAWSWEEPER_WORKER_RUNNER || 'blacksmith-4vcpu-ubuntu-2404' }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sweep.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ jobs:
name: Skip disabled target event
if: ${{ github.event_name == 'repository_dispatch' && github.event.client_payload.target_repo == 'openclaw/clawhub' && vars.CLAWSWEEPER_ENABLE_CLAWHUB != '1' }}
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- name: Explain skipped event
run: |
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ checkpoint, and status-only commits are intentionally omitted.
- Suppressed changelog-only OpenClaw PR review findings after model output so
contributor PRs do not get needs-changes or fix-required markers solely for
maintainer-owned release notes. Thanks @rubencu.
- Added explicit timeouts for disabled-target workflow guard jobs and
concurrency groups for write-side repair workflows. Thanks @ds4psb-ai.
- Gave manual exact-item review dispatches their own concurrency group so
targeted maintainer reviews no longer wait behind broad normal backfill runs.
- Downgraded screenshot-only browser runtime proof so ClawSweeper no longer accepts "no visible console/CSP violation" screenshots as sufficient real behavior proof. Thanks @BunsDev.
Expand Down