fix(azure): default to checkpointable OS disks#111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes Azure leases checkpointable by default after the interaction between Azure ephemeral OS disks and provider-native checkpoints showed that the old default could silently produce unusable checkpoint forks.
This follows two earlier changes:
Azure provider-native checkpoints from #99 made Azure OS disk snapshots part of the native checkpoint path, but Azure leases from #39 could default to ephemeral OS disks on supported D/F/E-family SKUs. Azure accepts a snapshot request for those VMs and reports success, but the resulting snapshot does not capture the live ephemeral OS disk state. This PR makes the checkpointable behavior the default instead.
StandardSSD_LRSOS disks.azureOSDisk/CRABBOX_AZURE_OS_DISKis set toautofor compatibility.--azure-os-disk ephemeral/azure.osDisk: ephemeralfor stateless leases that intentionally want local OS disks.Actual binary runs
Direct Azure default OS disk
This was run without
--azure-os-disk, using the direct Azure provider and the active Azure CLI login. Public IPs are omitted here.Observed output:
Azure VM OS disk verification:
az vm show \ -g crabbox-leases \ -n crabbox-tidal-lobster-775f7392 \ --query "storageProfile.osDisk.{name:name,caching:caching,diffDiskSettings:diffDiskSettings,managedDisk:managedDisk.storageAccountType,managedDiskId:managedDisk.id}" \ -o jsonObserved output:
{ "caching": "ReadWrite", "diffDiskSettings": null, "managedDisk": "StandardSSD_LRS", "managedDiskId": "/subscriptions/<redacted>/resourceGroups/crabbox-leases/providers/Microsoft.Compute/disks/crabbox-tidal-lobster-775f7392-osdisk", "name": "crabbox-tidal-lobster-775f7392-osdisk" }Cleanup:
Observed output:
Brokered Azure default OS disk
This was run against a local Wrangler coordinator on
127.0.0.1:8787with a temporary Azure service principal scoped to thecrabbox-leasesresource group. The Worker env intentionally setCRABBOX_AZURE_OS_DISK=autoto prove that broker-sideautonow resolves to a managed OS disk. Tokens, service-principal credentials, subscription IDs, and public IPs are omitted here.Health check:
Observed output:
{"ok":true,"service":"crabbox-coordinator"}Brokered warmup:
Observed output:
Azure VM OS disk verification:
az vm show \ -g crabbox-leases \ -n crabbox-blue-hermit-cc265b9b \ --query "storageProfile.osDisk.{name:name,caching:caching,diffDiskSettings:diffDiskSettings,managedDisk:managedDisk.storageAccountType,managedDiskId:managedDisk.id}" \ -o jsonObserved output:
{ "caching": "ReadWrite", "diffDiskSettings": null, "managedDisk": "StandardSSD_LRS", "managedDiskId": "/subscriptions/<redacted>/resourceGroups/crabbox-leases/providers/Microsoft.Compute/disks/crabbox-blue-hermit-cc265b9b-osdisk", "name": "crabbox-blue-hermit-cc265b9b-osdisk" }Cleanup:
Observed output:
Temporary credential cleanup:
Observed output:
Validation commands
Notes for review
managedis the default Azure OS disk mode now.autois retained as an accepted value for compatibility, but resolves tomanagedso Azure matches AWS/GCP checkpoint expectations by default.ephemeralis still available for users who explicitly want a local OS disk for stateless Azure leases.diffDiskSettings.option == Local, which is the only safe behavior for ephemeral OS disk VMs.scripts/live-smoke.shonmaindoes not include an Azure provider branch, so the Azure proof above was run directly instead of through that script.