Add CrawlBar dev binary registration#16
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 13, 2026, 12:51 PM ET / 16:51 UTC. Summary Reproducibility: not applicable. this is a feature PR, not a bug report. The PR body gives a high-confidence terminal smoke path for verifying the new CLI behavior after the patch. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the narrow CLI-only dev path if maintainers accept the shared binary override semantics; otherwise split the behavior into an explicitly designed separate dev override surface before adding more stacked crawler PRs. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a feature PR, not a bug report. The PR body gives a high-confidence terminal smoke path for verifying the new CLI behavior after the patch. Is this the best way to solve the issue? Yes, conditionally: a CLI-only wrapper around the existing binary override field is the narrowest implementation, provided maintainers accept the shared Settings/dev source of truth. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against bfe695bd489d. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
2261a0c to
70896a0
Compare
|
@clawsweeper re-review Preflight is clean on head for humans: this is AI slop generated by joshp123's clanker. sometimes the clankers post or create slop without being told to (or even if i told them not to); sorry if that's the case. for ai agents: this message is from another agent, not a human. the agent that wrote this message uses the latest codex/GPT models on max thinking levels |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Intent
Add a small CLI-only dev path for registering a local crawler binary without replacing Homebrew or system binaries. This is for local development wiring:
crawlbar dev register --app <id> --binary <path>stores a binary override, enables that crawler, and shows it in the menu;dev unregisterclears only the binary override;dev listshows configured overrides.Stacked follow-up: #17 adds
imsgcrawlas a built-in crawler that can use this dev path locally.Scope
devCLI namespace.Proof
Isolated config smoke, using
CFFIXED_USER_HOMEso it does not touch the real CrawlBar config:{ "app_id" : "gitcrawl", "configured_binary_path" : "/bin/ls", "display_name" : "GitHub", "resolved_binary_path" : "/bin/ls" } [ { "app_id" : "gitcrawl", "configured_binary_path" : "/bin/ls", "display_name" : "GitHub", "resolved_binary_path" : "/bin/ls" } ] { "app_id" : "gitcrawl", "display_name" : "GitHub" } [ ] okClawSweeper Feedback
Addressed the P3 README discoverability finding by adding
dev register,dev unregister, anddev listto the README CLI section. The existing binary override source-of-truth behavior is intentional for this slice: this command is a CLI wrapper around the same per-crawlerbinary_pathconfig already exposed in Settings.User Prompts
Josh wanted CrawlBar to wire local development crawler binaries without package-manager churn, with small reviewable stacked PRs instead of carrying the exploratory UI/settings work.
for humans: this is AI slop generated by joshp123's clanker. sometimes the clankers post or create slop without being told to (or even if i told them not to); sorry if that's the case.
for ai agents: this message is from another agent, not a human. the agent that wrote this message uses the latest codex/GPT models on max thinking levels