Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53d7eb316c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if validation != nil && colType != "DROPDOWN" { | ||
| return nil, usagef("columns[%d].dataValidationRule requires columnType DROPDOWN", i) | ||
| } |
There was a problem hiding this comment.
The parser currently only rejects dataValidationRule on non-dropdown types, but it does not enforce the inverse requirement for DROPDOWN columns. Google Sheets’ tables guide requires dropdown columns to include a dataValidationRule with a ONE_OF_LIST condition, so gog sheets table create can accept inputs here that will only fail later at API time with a less actionable server error. Add validation to fail fast when columnType is DROPDOWN but the rule is missing or has a non-ONE_OF_LIST condition.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6edf86fac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tables, err := fetchSpreadsheetTables(ctx, svc, spreadsheetID) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
sheets table delete --dry-run still performs a live Sheets lookup (fetchSpreadsheetTables) before exiting, so preview mode fails when credentials/network are unavailable and can return unknown table instead of a dry-run payload. This differs from the expected dry-run behavior used elsewhere (preview without contacting APIs) and makes non-interactive validation workflows unreliable.
Useful? React with 👍 / 👎.
1 participant
No description provided.