improve: FrozenDictionary command dispatch map in WindowsNodeClient#205
Merged
shanselman merged 2 commits intomasterfrom Apr 23, 2026
Merged
improve: FrozenDictionary command dispatch map in WindowsNodeClient#205shanselman merged 2 commits intomasterfrom
shanselman merged 2 commits intomasterfrom
Conversation
Replace O(n) linear capability scans with O(1) FrozenDictionary lookup. - Add _commandMap field (FrozenDictionary<string, INodeCapability>) - Add BuildCommandMap() to (re)build the map after each RegisterCapability call - Replace both FirstOrDefault dispatch calls with _commandMap.GetValueOrDefault - First-registered capability wins on command collision (preserves original semantics) - Add 3 tests: routing, unknown command, first-registered-wins collision Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace two O(n) FirstOrDefault(c => c.CanHandle(command)) scans with O(1) FrozenDictionary lookup. TryAdd preserves first-registered- wins semantics. Map rebuilt on each RegisterCapability() call (startup only, before ConnectAsync). Add event-path dispatch test to cover HandleNodeInvokeEventAsync in addition to the request-path tests. Based on Repo Assist PR #197, with additional test coverage. Closes #197
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O(1) FrozenDictionary lookup replacing O(n) FirstOrDefault scans for node command dispatch. Based on Repo Assist PR #197 with additional event-path test coverage identified during rubber-duck review.
4 tests: request-path routing, unknown command, collision, and event-path dispatch.
All 774 tests pass.