eng: add root NuGet.Config with package source mapping#215
Open
AlexAlves87 wants to merge 4 commits intoopenclaw:masterfrom
Open
eng: add root NuGet.Config with package source mapping#215AlexAlves87 wants to merge 4 commits intoopenclaw:masterfrom
AlexAlves87 wants to merge 4 commits intoopenclaw:masterfrom
Conversation
Without a root-level NuGet.Config, machine-level or user-level feeds could accidentally resolve packages, opening a dependency confusion vector. The <clear /> + packageSourceMapping locks all resolution exclusively to nuget.org. Mirrors the pattern already in src/OpenClaw.CommandPalette/nuget.config. OpenClaw.CommandPalette is unaffected (its local config also has <clear />). Closes openclaw#214. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo Assist raised #214 as a fallback review issue while commenting on #159.
Since this is a legitimate repo-wide hardening improvement and the repo does
not rely on private feeds, I picked it up here as a small standalone change.
This adds a root
NuGet.Configthat clears any inherited machine- oruser-level package sources and restricts restore exclusively to
nuget.orgvia package source mapping, closing the dependency-confusion vector described
in #214.
OpenClaw.CommandPaletteis unaffected: its localnuget.configalreadyuses
<clear />and the same mapping, so its behavior remains unchanged.No code changes. Build and test results are unchanged.
Closes #214.