Skip to content

Add data platform toolbox#390

Merged
katyalmohit merged 18 commits intomainfrom
dataplatform-toolbox
Jan 27, 2026
Merged

Add data platform toolbox#390
katyalmohit merged 18 commits intomainfrom
dataplatform-toolbox

Conversation

@katyalmohit
Copy link
Copy Markdown
Contributor

@katyalmohit katyalmohit commented Jan 13, 2026

Pull Request

Description

Add a page for data-platform toolbox. It manages organisations, users, locations and policies.

Fixes #389

How Has This Been Tested?

  • tested locally and on development
  • tested the UI with streamlit testing

Tests:

  • Organisations: create, get, delete
  • Users: create, get, delete, add/remove from organisations
  • Locations: create, list, get
  • Policies: create/get groups, add/remove location policies, add/remove groups to orgs

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@katyalmohit katyalmohit marked this pull request as draft January 13, 2026 09:03
Copy link
Copy Markdown
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, Ive left a few small comments for you to do.
And you mentioned to me that

  1. move some repeat functions in tests to conftest.py
  2. use
async with Channel(host=data_platform_host, port=data_platform_port) as channel:
     client = dp.DataPlatformDataServiceStub(channel)

in client, and you might have to move things to async

Copy link
Copy Markdown
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes, and nearly there

@katyalmohit katyalmohit marked this pull request as ready for review January 22, 2026 07:59
@katyalmohit katyalmohit marked this pull request as draft January 22, 2026 11:38
@katyalmohit katyalmohit marked this pull request as ready for review January 23, 2026 11:56
@peterdudfield
Copy link
Copy Markdown
Contributor

Good idea to update the readme.md with what this new directory does

@katyalmohit katyalmohit merged commit 80dc0f6 into main Jan 27, 2026
5 checks passed
@katyalmohit katyalmohit deleted the dataplatform-toolbox branch January 27, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Dataplatform Toolbox

2 participants