Merged
Conversation
peterdudfield
requested changes
Jan 19, 2026
Contributor
peterdudfield
left a comment
There was a problem hiding this comment.
This looks really good, Ive left a few small comments for you to do.
And you mentioned to me that
- move some repeat functions in tests to conftest.py
- use
async with Channel(host=data_platform_host, port=data_platform_port) as channel:
client = dp.DataPlatformDataServiceStub(channel)
in client, and you might have to move things to async
peterdudfield
requested changes
Jan 21, 2026
Contributor
peterdudfield
left a comment
There was a problem hiding this comment.
small changes, and nearly there
Contributor
|
Good idea to update the readme.md with what this new directory does |
peterdudfield
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Add a page for data-platform toolbox. It manages organisations, users, locations and policies.
Fixes #389
How Has This Been Tested?
Tests:
Checklist: