Skip to content

Wokring for NL and if there is no generation or foreacst data#395

Merged
peterdudfield merged 4 commits intomainfrom
dp-forecast
Feb 19, 2026
Merged

Wokring for NL and if there is no generation or foreacst data#395
peterdudfield merged 4 commits intomainfrom
dp-forecast

Conversation

@peterdudfield
Copy link
Copy Markdown
Contributor

@peterdudfield peterdudfield commented Feb 19, 2026

Pull Request

Description

  • get forecast page working for NL
  • gorecast page is there is no forecast data
  • forecast page works if there no generation data

builds on #394

How Has This Been Tested?

  • CI tests
  • tested locally
  • deployed on dev

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield changed the title Dp forecast Wokring for NL and if there is no generation or foreacst data Feb 19, 2026
@peterdudfield
Copy link
Copy Markdown
Contributor Author

Would you like to review this PR @CodeVishal-17?

@CodeVishal-17
Copy link
Copy Markdown
Contributor

Looks good to me 👍
I like the additional guards for empty DataFrames and the NL observer addition.
Thanks for building on the previous fix!

@peterdudfield peterdudfield merged commit f23a394 into main Feb 19, 2026
5 checks passed
@peterdudfield peterdudfield deleted the dp-forecast branch February 19, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants