fix: replace deprecated datetime.utcnow() in Elexon plotting and tests#414
Open
onurege3467 wants to merge 1 commit intoopenclimatefix:mainfrom
Open
fix: replace deprecated datetime.utcnow() in Elexon plotting and tests#414onurege3467 wants to merge 1 commit intoopenclimatefix:mainfrom
onurege3467 wants to merge 1 commit intoopenclimatefix:mainfrom
Conversation
Python 3.12+ deprecates datetime.utcnow(). Replaced with datetime.now(UTC) in both elexon_plots.py and its test file, preserving existing behavior for start/end datetime calculations. - src/plots/elexon_plots.py: import UTC, use datetime.now(UTC) - tests/test_elexon_plot.py: import UTC, use datetime.now(UTC) Fixes openclimatefix#403 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace deprecated
datetime.utcnow()with timezone-awaredatetime.now(UTC)in Elexon plotting code and tests, ensuring Python 3.12+ compatibility.Root Cause
datetime.utcnow()is deprecated in Python 3.12+ and emits deprecation warnings. The project specifiesrequires-python = ">=3.12", so this should use the timezone-aware alternative.Changes
src/plots/elexon_plots.py:from datetime import ... UTC+datetime.now(UTC)tests/test_elexon_plot.py:from datetime import ... UTC+datetime.now(UTC)Why This Is Safe
The new call returns a timezone-aware datetime in the same UTC offset that
datetime.utcnow()returned as naive. All start/end datetime calculations remain functionally equivalent. No test logic is changed — only thenowreference value is updated.Testing
Related