Skip to content

fix(proto): Modify timestamp validation #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devsjc merged 1 commit into from
Mar 26, 2026
Merged

fix(proto): Modify timestamp validation #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions proto/ocf/dp/dp-data.messages.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,16 @@ message Forecaster {

message TimeWindow {
/* The start of the time window, inclusive.
* Cannot be more than 7 days before end_timestamp_utc.
* Cannot be more than 7 days before end_timestamp_utc, nor more than 1 month in the future.
*/
google.protobuf.Timestamp start_timestamp_utc = 1 [
(buf.validate.field).required = true,
(buf.validate.field).timestamp = { gt: { seconds: 112000000}, lt_now: true }
(buf.validate.field).timestamp = { gt: { seconds: 112000000} },
(buf.validate.field).cel = {
id: "timestamp_not_too_far_in_future"
message: "start_timestamp_utc cannot be more than 30 days in the future"
expression: "this <= now + duration('720h')"
}
];
/* The end of the time window, inclusive.
* Cannot be more than 7 days after start_timestamp_utc.
Expand Down Expand Up @@ -139,7 +144,12 @@ message GetForecastAtTimestampRequest {
* If not specified, the current time will be used.
*/
optional google.protobuf.Timestamp timestamp_utc = 3 [
(buf.validate.field).timestamp = { gt: { seconds: 112000000} }
(buf.validate.field).timestamp = { gt: { seconds: 112000000} },
(buf.validate.field).cel = {
id: "timestamp_not_too_far_in_future"
message: "timestamp_utc cannot be more than 30 days in the future"
expression: "this <= now + duration('720h')"
}
];
Forecaster forecaster = 4 [
(buf.validate.field).required = true
Expand Down
Loading