Open
Conversation
Contributor
|
I wonder if the tests are failing becasue the timezon 'Z' got moved down to a |
Contributor
Author
|
Yeah I think def something like that with the datetime strings – right now we're only aware of the boolean attributes that are allowed to be in whatever case, so have just made it more specific for now. |
devsjc
approved these changes
Apr 2, 2026
| repr(sorted(permissions)), | ||
| ], | ||
| ) | ||
| ).replace("False", "false").replace("True", "true") |
Contributor
There was a problem hiding this comment.
couldnt you do lower?
And then I think in one of the tests you need to use t (not T) and z( not Z)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Forces all cache keys to lowercase by calling .lower() on the key_builder output, ensuring cache hits regardless of the case of query parameter values passed by the client.
Existing hardcoded warm keys are already lowercase so read/write consistency is maintained.
The @cache decorator uses key_builder for both lookup and store, so both paths are covered by this change.
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: