Skip to content

convert gsp_ids="" to None#273

Closed
peterdudfield wants to merge 2 commits intomainfrom
bug/gspids-empty
Closed

convert gsp_ids="" to None#273
peterdudfield wants to merge 2 commits intomainfrom
bug/gspids-empty

Conversation

@peterdudfield
Copy link
Copy Markdown
Contributor

@peterdudfield peterdudfield commented Apr 2, 2026

Pull Request

Description

Small change for converting gsp_ids

  1. Do it at the start of the route
  2. if "" then set to None

I tried using Annoted and AfterValidator but couldnt seem to get it working, I'm happy to try again if you prefer

Helps with https://github.com/openclimatefix/client-private/issues/337
(it wont fix this bug, as only the start time is set, but this might be something that needs to be fixed in the UI)

How Has This Been Tested?

  • CI tests

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as draft April 2, 2026 07:18
@peterdudfield peterdudfield marked this pull request as ready for review April 2, 2026 09:18
@peterdudfield
Copy link
Copy Markdown
Contributor Author

Ill close this due to openclimatefix/quartz-frontend#712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant