Recreate topology on previous test failure and run setup_teardown fixture once per test method#297
Open
zikkend wants to merge 2 commits into
Open
Conversation
zikkend
force-pushed
the
change_ptf_behavior_on_failure
branch
from
158777e to
affe1bc
Compare
…ture once per test method Signed-off-by: Denys Zikratyi <denys.zikratyi@gmail.com>
Signed-off-by: Denys Zikratyi <denys.zikratyi@gmail.com>
zikkend
force-pushed
the
change_ptf_behavior_on_failure
branch
from
affe1bc to
8d8378b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old behavior
When a test failed, the NPU was reset without recreating the topology, causing all subsequent tests to fail. In addition, the test class
setup_teardownfixture was executed only once per test class. If a test method within the class failed, the fixture was not run again, leaving the test environment in an inconsistent state and causing subsequent test methods in the same class to fail.New behavior
When a test fails, the NPU is reset and the topology is recreated before the next test is executed. Additionally, the test class
setup_teardownfixture is now executed once per test method instead of once per test classAs a result, tests are isolated from failures in previous test methods. However, the overall test execution time increases because
setup_teardownis invoked for every test method