Skip to content

store Location field as a label on started containers #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
brianneville wants to merge 2 commits into
base: master
Choose a base branch
from
Open

store Location field as a label on started containers #59

brianneville wants to merge 2 commits into from

Conversation

@brianneville
Copy link
Contributor

@brianneville brianneville commented Jan 21, 2026 •
edited
Loading

Store the location field from the
StartContainer/UpdateContainer messages
as a label on the started container.

if the label is unspecified (L_UNKNOWN) then
it is treated as L_PRIMARY as a default.

@brianneville
Copy link
Contributor Author

brianneville commented Jan 21, 2026

Note: this PR includes the changes from #58
When that PR merges ill rebase on top of it

@coveralls
Copy link

coveralls commented Jan 21, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 21441019778

Details

  • 32 of 34 (94.12%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 63.69%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server/update_container.go 2 4 50.0%
Totals Coverage Status
Change from base Build 21439864552: 0.3%
Covered Lines: 1719
Relevant Lines: 2699
💛 - Coveralls

@brianneville brianneville changed the title Label location store Location field as a label on started containers Jan 21, 2026
alshabib
alshabib reviewed Jan 28, 2026
View reviewed changes
@alshabib
Copy link
Collaborator

alshabib commented Jan 28, 2026

This needs a rebase as well and then it can be submitted.

@brianneville
add location label for StartContainer/UpdateContainer
dfcbf2c 
Store the location field from the
StartContainer/UpdateContainer messages
as a label on the started container.

if the label is unspecified (L_UNKNOWN) then
it is treated as L_PRIMARY as a default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alshabib alshabib alshabib approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brianneville @coveralls @alshabib