schema: make fs.go dynamic#543
Closed
vbatts wants to merge 1 commit intoopencontainers:masterfrom
Closed
Conversation
Contributor
|
On Mon, Jan 30, 2017 at 09:47:59AM -0800, Vincent Batts wrote:
the schema-fs is needed dynamically and should be generated as such.
Further, it is often a tidious cause of rebasing. Therefore, just
make it generated everytime and not even managed in git.
…
M schema/fs.go (278)
As of d8a9fea, you still have it in Git. I agree that there are not
bumping fs.go with each PR would be nice because it would avoid those
rebases. However, I think consumers of this library will need a
current fs.go when they vendor us. In the “rarely-bump fs.go”
approach I sketched out in [1], we'd keep fs.go in version control but
only bump it as part of cutting a release. Maybe that's what you're
aiming for here (in which case, you probably want to drop your local
fs.go bump ;).
[1]: #530 (comment)
|
the schema-fs is needed dynamically and should be generated as such. Further, it is often a tidious cause of rebasing. Therefore, just make it generated everytime and not even managed in git. Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
d8a9fea to
6d7ac51
Compare
Member
Author
|
i forgot about the imports and go get. this is less than ideal. |
Contributor
|
On Tue, Jan 31, 2017 at 10:28:08AM -0800, Vincent Batts wrote:
i forgot about the imports and go get. this is less than ideal.
Does that mean we're coming back around towards the approach I floated
in #530? If so, I can get back to work on figuring how to work around
the compression issue [1].
[1]: #530 (comment)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the schema-fs is needed dynamically and should be generated as such.
Further, it is often a tidious cause of rebasing.
Therefore, just make it generated everytime and not even managed in git.
Signed-off-by: Vincent Batts vbatts@hashbangbash.com