Fix/cgroup2 bind mount shared cgroupns#5267
Open
xujihui1985 wants to merge 2 commits intoopencontainers:mainfrom
Open
Fix/cgroup2 bind mount shared cgroupns#5267xujihui1985 wants to merge 2 commits intoopencontainers:mainfrom
xujihui1985 wants to merge 2 commits intoopencontainers:mainfrom
Conversation
xujihui1985
force-pushed
the
fix/cgroup2-bind-mount-shared-cgroupns
branch
2 times, most recently
from
ecc4ae8 to
9a08cc5
Compare
When cgroup namespaces is host, mounting a new cgroup2 fs instance for /sys/fs/cgroup can affect the host-visible cgroupfs mount state, including options such as nsdelegate. Avoid that by preferring a bind mount of the existing cgroup v2 hierarchy when cgroupns is host. Keep the existing cgroup2 mount-first logic for private cgroup namespaces, including the EPERM/EBUSY fallback to a bind mount and the rootless ENOENT masking behavior. Signed-off-by: sean <xujihui1985@gmail.com>
in host cgroupns, mount cgroupfs should not mutate the global superblock mount options, the test is to check when create container with host cgroupns, it should not mutate the global superblock options of host cgroupfs Signed-off-by: sean <xujihui1985@gmail.com>
xujihui1985
force-pushed
the
fix/cgroup2-bind-mount-shared-cgroupns
branch
from
9a08cc5 to
922bd42
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cgroup namespaces is host, mounting a new cgroup2 fs instance for /sys/fs/cgroup can affect the host-visible cgroupfs mount state, including options such as nsdelegate.
Avoid that by preferring a bind mount of the existing cgroup v2 hierarchy when cgroupns is host. Keep the existing cgroup2 mount-first logic for private cgroup namespaces, including the EPERM/EBUSY fallback to a bind mount and the rootless ENOENT masking behavior.
this PR fix issue #5258