Add a Simulation Property Editor component to our SimulationExperimentView component #368
Conversation
… peer dependencies. They were originally here so that we could easily find out when a new version of them is available (since we "manually" import them), but it's not good to have things under `peerDependencies` unless actually needed. So, removing them... which means that we will need to "manually" check whether a new version of `mathjs` and/or `plotly.js-gl2d-dist-min` is available.
… the toolbar. The objective is for the center template to always in the same place.
…igonometric operators.
…to show a context menu.
…to the settings. Maybe temporary... or not.
There was a problem hiding this comment.
Pull request overview
This pull request adds a comprehensive Simulation Property Editor component to the SimulationExperimentView, enabling users to configure simulation parameters, solver settings, and interactive UI JSON through a dedicated settings dialog.
Changes:
- Refactored C++ API to better organize SED-ML related functions by entity type (SedModel, SedOneStep, SedUniformTimeCourse, SolverCvode)
- Added a new SimulationExperimentViewSettingsDialog component with tabs for simulation, solvers, interactive, and miscellaneous settings
- Redesigned IssuesView component with improved visual design showing issue counts and severity indicators
- Enhanced interactive mode with improved run tracking, color selection, and live update controls
Reviewed changes
Copilot reviewed 27 out of 29 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/src/libopencor/src/sed.h | Reorganized function declarations by entity type (SedModel, SedOneStep, SedUniformTimeCourse, SolverCvode) |
| src/renderer/src/libopencor/src/sed.cpp | Renamed and reorganized functions, added SolverCvode API for accessing CVODE's maximum step |
| src/renderer/src/libopencor/src/main.cpp | Updated exports to match renamed functions |
| src/renderer/src/libopencor/locSedApi.ts | Renamed simulation classes (e.g., SedSimulationUniformTimeCourse → SedUniformTimeCourse), added SolverCvode class |
| src/renderer/src/libopencor/locUiJsonApi.ts | Renamed uiJsonIssues to validateUiJson, added removeNulls utility, improved null checking |
| src/renderer/src/libopencor/locLoggerApi.ts | Added INFORMATION issue type to enum |
| src/renderer/src/libopencor/locApi.ts | Updated exports for renamed classes and validation function |
| src/renderer/src/components/widgets/GraphPanelWidgetPalette.ts | Changed palette structure from array to Record for color name lookups |
| src/renderer/src/components/views/SimulationExperimentView.vue | Major updates: added settings dialog integration, improved run tracking UI, enhanced interactive controls |
| src/renderer/src/components/views/IssuesView.vue | Complete redesign with header, severity badges, and improved visual layout |
| src/renderer/src/components/dialogs/SimulationExperimentViewSettingsDialog.vue | New 1359-line component providing comprehensive simulation and UI JSON configuration |
| src/renderer/src/components/dialogs/BaseDialog.vue | Added isDialogActive export for checking if any dialog is open |
| src/renderer/src/common/common.ts | Added isDivisible and downloadFile utility functions |
| package.json | Updated dependencies and version to 0.20260128.0 |
| src/preload/index.ts | Updated API exports to match renamed functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agarny
force-pushed
the
issue289
branch
2 times, most recently
from
80016ca to
381ecc6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 27 out of 29 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/renderer/src/components/dialogs/SimulationExperimentViewSettingsDialog.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 27 out of 29 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 27 out of 29 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…E's maximum step.
… model parameters.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 32 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Fixes #289.