fix component name inconsistencies and add ci test pipeline#13
Open
christianhuening wants to merge 2 commits intomainfrom
Open
fix component name inconsistencies and add ci test pipeline#13christianhuening wants to merge 2 commits intomainfrom
christianhuening wants to merge 2 commits intomainfrom
Conversation
trevex
reviewed
Feb 17, 2026
trevex
requested changes
Feb 24, 2026
Contributor
trevex
left a comment
There was a problem hiding this comment.
Currently in the last commit that ran the tests, both the keycloak- and cnpg-test-suite failed.
In the most recent commit, as there were no changes to the OCM components, so the tests were not run again.
I would propose two additional changes:
- include
.github/workflows/test-${OCM_COMPONENT}.yml(pseude-code) in the path filters inci.yml, so that the test suites are also run, when there are changes to the suites - the test-suites are expensive and should not be run for every PR, but rather require the
ok-to-testlabel on the PR, so an explicit approval by a maintainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need review!