Skip to content

fix component name inconsistencies and add ci test pipeline#13

Open
christianhuening wants to merge 2 commits intomainfrom
fix-issues-and-add-ci-quality-checks
Open

fix component name inconsistencies and add ci test pipeline#13
christianhuening wants to merge 2 commits intomainfrom
fix-issues-and-add-ci-quality-checks

Conversation

@christianhuening
Copy link
Contributor

Need review!

Copy link
Contributor

@trevex trevex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently in the last commit that ran the tests, both the keycloak- and cnpg-test-suite failed.

In the most recent commit, as there were no changes to the OCM components, so the tests were not run again.

I would propose two additional changes:

  • include .github/workflows/test-${OCM_COMPONENT}.yml (pseude-code) in the path filters in ci.yml, so that the test suites are also run, when there are changes to the suites
  • the test-suites are expensive and should not be run for every PR, but rather require the ok-to-test label on the PR, so an explicit approval by a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants