Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,14 @@ private void addDeletionWrapperWorkflowParameters(String catalogItemId,
);
}
var dispatchedWorkflowParams = action.getParameters().stream().map(CreateIncidentParameter::getName).collect(Collectors.toSet());
// We need to add in a static way these parameters, so the dispatcher can send them
// to the dispatched workflow
dispatchedWorkflowParams.add("project_key");
dispatchedWorkflowParams.add("cluster_location");
dispatchedWorkflowParams.add("component_id");
dispatchedWorkflowParams.add("is_deployed");
dispatchedWorkflowParams.add("change_number");
dispatchedWorkflowParams.add("reason");

var allParams = new ArrayList<>(action.getParameters());
var createIncidentParamDispatchedWorkflowParams = CreateIncidentParameter.builder()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,31 @@ void givenWrapperWorkflow_whenRequestDeletion_thenAddsWrapperParameters() {
assertThat(facade.getParameterString(action, "deletion_workflow_timeout_seconds")).isEqualTo("60");
}

@Test
void givenWrapperWorkflow_whenRequestDeletion_thenAddsMandatoryStaticParameters() {
var action = CreateIncidentActionMother.of();
action.setParameters(new ArrayList<>());

when(authenticationProvider.getAccessToken()).thenReturn("token");

ReflectionTestUtils.invokeMethod(
facade,
"addDeletionWrapperWorkflowParameters",
"catalogId",
"wfId",
null,
"60",
action
);

assertThat(facade.getParameterString(action, "dispatched_workflow_params")).contains("project_key");
assertThat(facade.getParameterString(action, "dispatched_workflow_params")).contains("cluster_location");
assertThat(facade.getParameterString(action, "dispatched_workflow_params")).contains("component_id");
assertThat(facade.getParameterString(action, "dispatched_workflow_params")).contains("is_deployed");
assertThat(facade.getParameterString(action, "dispatched_workflow_params")).contains("change_number");
assertThat(facade.getParameterString(action, "dispatched_workflow_params")).contains("reason");
}

@Test
void givenBothCatalogItemIdAndSlugEmpty_whenResolveCatalogItemIdIsCalled_thenReturnsNull() {
// when
Expand Down
Loading