Open
Conversation
Before, after hydrodynamic mixing, the bed composition of the mixed layers was reset to the average of those layers. On shorter term scale, this approach seems to work, but after longer simulation periods, the approach appears to result in an underestimation of fine particles emerging in the top layer. If armouring occurs for a long period, the average bed composition of all layers starts to become more coarse. After several years, during mixing no small particles were emerging to the top layer anymore. To solve this, an optional mixing method could be implemented that does not reset the mixed bed to the current average of the layers, but to the original bed composition. method_mixing = layer_average (default) OR method_mixing = reset_initial (new)
Collaborator
|
@christavanijzendoorn and @bartvanwesten |
Collaborator
|
I agree with Sierd that there's no extra bedcomp_mixing_file needed. On line 109 of bed.py the bedcomp file is read and immediately converted into the mass parameter. This means the bedcomp file will still contain the initial bed composition and can be used in Bart's code to reset the bed composition. I think that'd save some lines of code and loading two bedcomp files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, after hydrodynamic mixing, the bed composition of the mixed layers was reset to the average of those layers.
On shorter term scale, this approach seems to work, but after longer simulation periods, the approach appears to result in an underestimation of fine particles emerging in the top layer. If armouring occurs for a long period, the average bed composition of all layers starts to become more coarse. After several years, during mixing no small particles were emerging to the top layer anymore.
To solve this, an optional mixing method could be implemented that does not reset the mixed bed to the current average of the layers, but to the original bed composition.
method_mixing = layer_average (default)
OR
method_mixing = reset_initial (new)