Skip to content

chore(ci): Update .nvmrc to node 20#32

Merged
brian-smith-tcril merged 1 commit intoopenedx:masterfrom
brian-smith-tcril:node-20-nvmrc
Jun 6, 2025
Merged

chore(ci): Update .nvmrc to node 20#32
brian-smith-tcril merged 1 commit intoopenedx:masterfrom
brian-smith-tcril:node-20-nvmrc

Conversation

@brian-smith-tcril
Copy link
Contributor

Noticed the release workflow failed https://github.com/openedx/brand-openedx/actions/runs/15495997755/job/43632751864 because it was using node 18 and a version of semantic-release that isn't compatible with node 18. We've worked around this in the past by specifying a version of semantic-release that is compatible with node 18, but I decided updating the .nvmrc to use node 20 makes more sense because we should be using node 20 here anyways.

I also verified that running npm ci, npm run build works with node 20. I also tested running npm install and saw no changes to the package lock.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! 👍🏼

@brian-smith-tcril brian-smith-tcril merged commit 89f0594 into openedx:master Jun 6, 2025
2 checks passed
dcoa pushed a commit to fccn/brand-nau that referenced this pull request Nov 27, 2025
sandroscosta pushed a commit to fccn/brand-nau that referenced this pull request Dec 4, 2025
MohamedAhmedG pushed a commit to zeit-labs/eduba-brand-openedx that referenced this pull request Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants