docs: Document the PROXY setting and why you would want to use it#235
docs: Document the PROXY setting and why you would want to use it#235MoisesGSalas merged 1 commit intomasterfrom
Conversation
I just grabbed the commit message for f4cb95b/PR #36. I haven't actually verified whether this is still accurate -- note that this is from 2015, written for Python 2. For all I know this performance concern is no longer relevant. It also may not be relevant for codejail-service, which is a much smaller process than edxapp.
MoisesGSalas
left a comment
There was a problem hiding this comment.
Thanks, even if it no longer applies, having the rationale at hand is much better than doing archeology.
|
I ended up doing some more research -- and yeah, I suspect this is no longer needed. Ned confirmed that this was put in place because long-lived edxapp processes would eventually consume more than 50% of RAM and would then be unable to fork. Apparently subprocess execution involves first forking the parent, then having the child run However, I looked into the implementation of So yeah, this looks like an optimization that should now be unnecessary. |
I just grabbed the commit message for f4cb95b/PR #36. I haven't actually verified whether this is still accurate -- note that this is from 2015, written for Python 2. For all I know this performance concern is no longer relevant. It also may not be relevant for codejail-service, which is a much smaller process than edxapp.