Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion course_discovery/apps/course_metadata/people.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,19 @@ def _get_api_client(self, partner):
)

def _get_node_data(self, person):
# Build full name safely to avoid "null" appearing on marketing site
full_name = " ".join(
part for part in [person.given_name, person.family_name]
if part
)

# Preserve salutation if present
if person.salutation:
full_name = f"{person.salutation} {full_name}"

return {
'field_person_slug': person.slug,
'title': person.full_name,
'title': full_name.strip(),
'type': 'person',
'status': 1 if person.published else 0
}
Expand Down
37 changes: 37 additions & 0 deletions course_discovery/apps/course_metadata/tests/test_people.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,43 @@ def test_person_create_json(self, mock_create_node):
})
self.assertDictEqual(data, expected)

def test_person_without_family_name(self):
person = PersonFactory(
partner=self.partner,
given_name='User',
family_name=None
)

people = MarketingSitePeople()
data = people._get_node_data(person) # pylint: disable=protected-access

assert data['title'] == 'User'

def test_person_with_empty_family_name(self):
person = PersonFactory(
partner=self.partner,
given_name='User',
family_name=''
)

people = MarketingSitePeople()
data = people._get_node_data(person) # pylint: disable=protected-access

assert data['title'] == 'User'

def test_person_with_salutation(self):
person = PersonFactory(
partner=self.partner,
salutation='Dr.',
given_name='Jane',
family_name='Smith'
)

people = MarketingSitePeople()
data = people._get_node_data(person) # pylint: disable=protected-access

assert data['title'] == 'Dr. Jane Smith'

@responses.activate
def test_person_create_failed(self):
self.mock_api_client(200)
Expand Down
Loading