feat: translate STUDIO_BASE_URL to cmsBaseUrl in getConfig#2
Merged
arbrandes merged 1 commit intoMay 7, 2026
Merged
Conversation
Mirrors edx-platform's SITE_CONFIG_TRANSLATION_MAP entry so legacy MFE callers reading getConfig().STUDIO_BASE_URL resolve against getSiteConfig().cmsBaseUrl. Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
force-pushed
the
arbrandes/translate-cms-base-url
branch
from
May 6, 2026 23:14
27e1f25 to
ea6fc9f
Compare
brian-smith-tcril
approved these changes
May 7, 2026
|
🎉 This PR is included in version 1.0.0-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
STUDIO_BASE_URL -> cmsBaseUrltoSITE_CONFIG_TRANSLATION_MAPinsrc/platform/getConfig.ts, mirroring the entry in edx-platform'slms/djangoapps/mfe_config_api/views.py. Legacy MFE callers readinggetConfig().STUDIO_BASE_URLnow resolve againstgetSiteConfig().cmsBaseUrl. README's enumerated list of translated keys is updated to match.The existing test suite covers the translation pattern generically via
LMS_BASE_URLand friends, soSTUDIO_BASE_URLfalls into the same equivalence class without needing a dedicated case.LLM usage notice
Built with assistance from Claude.