chore: add integration tests for threading#235
Conversation
|
Thanks for the pull request, @Henrrypg! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 69 69
Lines 8086 8090 +4
Branches 432 432
=======================================
+ Hits 7708 7712 +4
Misses 283 283
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
felipemontoya
left a comment
There was a problem hiding this comment.
The tests look good to me, specially the third, but I think we should refactor them into using the provider_capabilities dict.
| """ | ||
| When session.remote_response_id points to a non-existent / expired | ||
| OpenAI thread, the processor must catch previous_response_not_found, | ||
| clear the stale ID, start a fresh thread, and return a valid response. |
There was a problem hiding this comment.
Should we start a completely fresh thread or prehaps re-load the conversation we already have in submissions?
There was a problem hiding this comment.
I think we may leave this as a fresh thread and left an issue to solve apart with that new feature based on the fact of thread ids has expiration
This PR add some missing integration tests for threading