Skip to content

chore: add integration tests for threading#235

Open
Henrrypg wants to merge 3 commits into
openedx:mainfrom
eduNEXT:hpg/threading-tests
Open

chore: add integration tests for threading#235
Henrrypg wants to merge 3 commits into
openedx:mainfrom
eduNEXT:hpg/threading-tests

Conversation

@Henrrypg

Copy link
Copy Markdown
Contributor

This PR add some missing integration tests for threading

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Henrrypg!

This repository is currently maintained by @felipemontoya.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 18, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 18, 2026
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.32%. Comparing base (98f555e) to head (8a4b4fc).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files          69       69           
  Lines        8086     8090    +4     
  Branches      432      432           
=======================================
+ Hits         7708     7712    +4     
  Misses        283      283           
  Partials       95       95           
Flag Coverage Δ
unittests 95.32% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@felipemontoya felipemontoya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look good to me, specially the third, but I think we should refactor them into using the provider_capabilities dict.

Comment thread backend/tests/integration/test_threading.py Outdated
"""
When session.remote_response_id points to a non-existent / expired
OpenAI thread, the processor must catch previous_response_not_found,
clear the stale ID, start a fresh thread, and return a valid response.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start a completely fresh thread or prehaps re-load the conversation we already have in submissions?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may leave this as a fresh thread and left an issue to solve apart with that new feature based on the fact of thread ids has expiration

Comment thread backend/tests/integration/test_threading.py Outdated
Comment thread backend/tests/integration/test_threading.py Outdated
Comment thread backend/tests/integration/test_threading.py Outdated
Comment thread backend/tests/integration/test_threading.py Outdated
Comment thread backend/tests/integration/test_threading.py Outdated
Comment thread backend/tests/integration/test_threading.py Outdated
Comment thread backend/tests/integration/test_threading.py Outdated
Comment thread backend/tests/integration/test_threading.py Outdated
Comment thread backend/tests/integration/test_threading.py Outdated
Comment thread backend/tests/integration/test_threading.py
Comment thread backend/tests/integration/test_threading.py Outdated
@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Jun 23, 2026
Comment thread backend/tests/integration/conftest.py Outdated
Comment thread backend/tests/integration/test_threading.py Outdated
Comment thread backend/tests/integration/test_threading.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: In Eng Review

Development

Successfully merging this pull request may close these issues.

4 participants