Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/openedx_content/applets/backup_restore/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ class EntityVersionSerializer(serializers.Serializer): # pylint: disable=abstra
"""
Serializer for publishable entity versions.
"""
title = serializers.CharField(required=True)
# We allow_blank because empty unit titles are legal and common.
title = serializers.CharField(required=True, allow_blank=True)

created = serializers.DateTimeField(required=True, default_timezone=timezone.utc)
version_num = serializers.IntegerField(required=True)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ version_num = 2
# ### Versions

[[version]]
title = "Unit1"
title = ""
version_num = 2

[version.container]
Expand Down
23 changes: 23 additions & 0 deletions tests/openedx_content/applets/backup_restore/test_restore.py
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,29 @@ def test_error_no_metadata_section(self):
expected_error = "Errors encountered during restore:\npackage.toml meta section: {'non_field_errors': [Er"
assert expected_error in log_content

def test_restore_with_blank_unit_title(self):
"""
Restoring should succeed when a container version has a blank title.

Blank titles are legal and common -- content imported from courses
(e.g. via the modulestore migrator) frequently has untitled units, and
such content can be backed up. Restoring that same archive must work.

The ``library_backup`` fixture's ``unit1`` deliberately has a blank
title to exercise this path.
"""
result = LearningPackageUnzipper(self.zip_file, package_ref="lib-xx:WGU:LIB_C001").load()

assert result["status"] == "success", f"Restore failed: {result['log_file_error']}"
assert result["log_file_error"] is None

lp = publishing_api.LearningPackage.objects.get(package_ref="lib-xx:WGU:LIB_C001")
unit = containers_api.get_containers(learning_package_id=lp.id).get(
publishable_entity__entity_ref="unit1-b7eafb"
)
draft_version = publishing_api.get_draft_version(unit.publishable_entity.id)
assert draft_version.title == ""

def test_success_metadata_using_user_context(self):
"""Test that metadata is correctly extracted from learning_package.toml."""
restore_result = LearningPackageUnzipper(self.zip_file, user=self.user).load()
Expand Down