feat: add filters to support logistration integration - #337
Open
pwnage101 wants to merge 1 commit into
Open
Conversation
pwnage101
commented
Mar 24, 2026
pwnage101
force-pushed
the
pwnage101/ENT-11568
branch
3 times, most recently
from
July 13, 2026 19:47
0fa2f77 to
8651fc4
Compare
pwnage101
force-pushed
the
pwnage101/ENT-11568
branch
3 times, most recently
from
July 14, 2026 05:01
5ebe0d6 to
c0c46d4
Compare
pwnage101
changed the title
There was a problem hiding this comment.
Pull request overview
This PR extends the openedx_filters.learning public filter surface to support “logistration” (combined login/registration) and related auth flows, aligning the filters library with new integration points in edx-platform/enterprise.
Changes:
- Added six new learning filters for logistration context/response customization, MFE redirect control, post-login redirect override, and TPA form overrides.
- Added two structural
Protocoltypes (FormDescriptionProtocol,ProviderConfigProtocol) to document the minimal interface passed to pipeline steps. - Added/updated test coverage for the new filters, and bumped package version + changelog entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| openedx_filters/learning/filters.py | Adds new logistration/auth-related filters and protocol structural types. |
| openedx_filters/learning/tests/test_filters.py | Adds unit tests validating new filters’ filter_type values and passthrough/exception behavior. |
| openedx_filters/init.py | Bumps package version to 3.9.0. |
| CHANGELOG.rst | Adds a 3.9.0 changelog entry describing the new filters and protocols. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pwnage101
force-pushed
the
pwnage101/ENT-11568
branch
2 times, most recently
from
July 22, 2026 01:47
0c4ee36 to
2f95918
Compare
kiram15
reviewed
Jul 27, 2026
| """ | ||
|
|
||
| def test_filter_type(self): | ||
| self.assertEqual( |
Contributor
There was a problem hiding this comment.
We should be using python asserts instead of unittest ones
* Added new ``LogistrationContextRequested`` filter * Added new ``PostLoginRedirectURLRequested`` filter * Added new ``LoginFormTPAOverridesRequested`` filter * Added new ``RegistrationFormTPAOverridesRequested`` filter * Added new ``LogistrationResponseRendered`` filter * Added ``FormDescriptionProtocol`` and ``ProviderConfigProtocol`` structural types declaring the minimal surface the TPA-override filters pass to pipeline steps ENT-11568
pwnage101
force-pushed
the
pwnage101/ENT-11568
branch
from
July 29, 2026 02:58
57a747a to
6d579f6
Compare
pwnage101
marked this pull request as ready for review
July 29, 2026 03:17
iloveagent57
approved these changes
Jul 29, 2026
iloveagent57
left a comment
iloveagent57
left a comment
There was a problem hiding this comment.
Looks good, one small suggestion to DRY things up a tiny bit.
Comment on lines
+2144
to
+2149
| data = super().run_pipeline( | ||
| form_desc=form_desc, | ||
| running_pipeline=running_pipeline, | ||
| current_provider=current_provider, | ||
| ) | ||
| return data["form_desc"], data["running_pipeline"], data["current_provider"] |
There was a problem hiding this comment.
is this identical to the LoginFormTPAOverridesRequested.run_filter() definition?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LogistrationContextRequestedfilterPostLoginRedirectURLRequestedfilterLoginFormTPAOverridesRequestedfilterRegistrationFormTPAOverridesRequestedfilterLogistrationResponseRenderedfilterFormDescriptionProtocolandProviderConfigProtocolstructural types declaring the minimal surface the TPA-override filters pass to pipeline stepsENT-11568
Integration Testing
See openedx/edx-enterprise#2551 (comment)
Related: