feat: update Icon to be ts and remove all stuff#4136
feat: update Icon to be ts and remove all stuff#4136holaontiveros wants to merge 1 commit intoopenedx:release-23.xfrom
Conversation
|
Thanks for the pull request, @holaontiveros! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx-v23 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Converted from JSX to TSX with native TypeScript types - Removed PropTypes in favor of TypeScript interfaces - Replaced defaultProps with default parameter values - Added proper TypeScript interfaces for IconProps and SvgAttrs - Removed obsolete index.d.ts file - Fixed TypeScript compilation errors Co-authored-by: Claude Sonnet 4 <claude@anthropic.com>
250ce89 to
2c45014
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.x #4136 +/- ##
================================================
+ Coverage 94.39% 94.40% +0.01%
================================================
Files 242 242
Lines 4296 4305 +9
Branches 1020 986 -34
================================================
+ Hits 4055 4064 +9
Misses 237 237
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Addresses #3744
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
Post-merge Checklist