Skip to content

feat: convert StatefulButton to TypeScript#4138

Open
wgu-jesse-stewart wants to merge 1 commit intoopenedx:release-23.xfrom
WGU-Open-edX:wgu-jesse-stewart/stateful-button-tsx
Open

feat: convert StatefulButton to TypeScript#4138
wgu-jesse-stewart wants to merge 1 commit intoopenedx:release-23.xfrom
WGU-Open-edX:wgu-jesse-stewart/stateful-button-tsx

Conversation

@wgu-jesse-stewart
Copy link

@wgu-jesse-stewart wgu-jesse-stewart commented Feb 24, 2026

  • Convert StatefulButton from .jsx to .tsx
  • Remove propTypes and defaultProps (React 19 ready)
  • Move defaults to function parameter defaults
  • Convert test file to TypeScript
  • Update src/index.ts to move StatefulButton to typed exports
  • Add ESLint override for .tsx files to allow JSX

Addresses #3739 and #3744

- Convert StatefulButton from .jsx to .tsx
- Remove propTypes and defaultProps (React 19 ready)
- Move defaults to function parameter defaults
- Convert test file to TypeScript
- Update src/index.ts to move StatefulButton to typed exports
- Add ESLint override for .tsx files to allow JSX

Addresses openedx#3739 and openedx#3744

Co-Authored-By: Claude <noreply@anthropic.com>
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Feb 24, 2026
@openedx-webhooks
Copy link

Thanks for the pull request, @wgu-jesse-stewart!

This repository is currently maintained by @openedx/committers-paragon.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for paragon-openedx-v23 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 708800e
🔍 Latest deploy log https://app.netlify.com/projects/paragon-openedx-v23/deploys/699e1c37dc77e80008b2ce9d
😎 Deploy Preview https://deploy-preview-4138--paragon-openedx-v23.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Feb 24, 2026
@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Feb 24, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Feb 24, 2026
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.40%. Comparing base (dfc69e2) to head (708800e).
⚠️ Report is 7 commits behind head on release-23.x.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-23.x    #4138      +/-   ##
================================================
+ Coverage         94.39%   94.40%   +0.01%     
================================================
  Files               242      242              
  Lines              4296     4304       +8     
  Branches           1020      984      -36     
================================================
+ Hits               4055     4063       +8     
  Misses              237      237              
  Partials              4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you fix the docstring I suggested.

The only other thing I noticed is that the inherited onClick prop disappeared from the props documentation. See https://paragon-openedx.netlify.app/components/statefulbutton/#props-api . It might be good to declare it explicitly so it shows up in the docs.

labels: { [key: string]: React.ReactNode };
/** Each state has an `icon`. */
icons?: { [key: string]: React.ReactNode };
/** Each state has a `disabledState` */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Each state has a `disabledState` */
/** States listed in `disabledStates` will not be clickable */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

4 participants