feat: convert StatefulButton to TypeScript#4138
feat: convert StatefulButton to TypeScript#4138wgu-jesse-stewart wants to merge 1 commit intoopenedx:release-23.xfrom
Conversation
- Convert StatefulButton from .jsx to .tsx - Remove propTypes and defaultProps (React 19 ready) - Move defaults to function parameter defaults - Convert test file to TypeScript - Update src/index.ts to move StatefulButton to typed exports - Add ESLint override for .tsx files to allow JSX Addresses openedx#3739 and openedx#3744 Co-Authored-By: Claude <noreply@anthropic.com>
|
Thanks for the pull request, @wgu-jesse-stewart! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx-v23 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.x #4138 +/- ##
================================================
+ Coverage 94.39% 94.40% +0.01%
================================================
Files 242 242
Lines 4296 4304 +8
Branches 1020 984 -36
================================================
+ Hits 4055 4063 +8
Misses 237 237
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bradenmacdonald
left a comment
There was a problem hiding this comment.
LGTM, if you fix the docstring I suggested.
The only other thing I noticed is that the inherited onClick prop disappeared from the props documentation. See https://paragon-openedx.netlify.app/components/statefulbutton/#props-api . It might be good to declare it explicitly so it shows up in the docs.
| labels: { [key: string]: React.ReactNode }; | ||
| /** Each state has an `icon`. */ | ||
| icons?: { [key: string]: React.ReactNode }; | ||
| /** Each state has a `disabledState` */ |
There was a problem hiding this comment.
| /** Each state has a `disabledState` */ | |
| /** States listed in `disabledStates` will not be clickable */ |
Addresses #3739 and #3744