refactor: convert popover to typescript#4143
refactor: convert popover to typescript#4143jacobo-dominguez-wgu wants to merge 1 commit intoopenedx:release-23.xfrom
Conversation
✅ Deploy Preview for paragon-openedx-v23 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-23.x #4143 +/- ##
================================================
- Coverage 94.39% 94.26% -0.13%
================================================
Files 242 242
Lines 4296 4306 +10
Branches 1020 986 -34
================================================
+ Hits 4055 4059 +4
- Misses 237 243 +6
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Part of #3739 Popover component
Convert StatefulButton from .jsx to .tsx
Remove propTypes and defaultProps (React 19 ready)
Move defaults to function parameter defaults
Convert test file to TypeScript
Update src/index.ts to move StatefulButton to typed exports
Merge Checklist
exampleapp?Post-merge Checklist