Skip to content

Features/#960 add vom for ror and reservoir - #1255

Open
CarlosEpia wants to merge 3 commits into
devfrom
features/#960-Add-VOM-for-ror-and-reservoir
Open

Features/#960 add vom for ror and reservoir#1255
CarlosEpia wants to merge 3 commits into
devfrom
features/#960-Add-VOM-for-ror-and-reservoir

Conversation

@CarlosEpia

@CarlosEpia CarlosEpia commented May 8, 2025

Copy link
Copy Markdown
Contributor

Fixes #960 .

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the workflow is running successful in test mode.
  • the workflow is running successful in Everything mode.

@khelfen

khelfen commented May 12, 2025

Copy link
Copy Markdown
Contributor

This PR is using the wrong base branch (dev), isn't it? Should be release/v.2.0.0 I think?

@CarlosEpia
CarlosEpia changed the base branch from dev to release/v2.0.0 May 16, 2025 10:03
@CarlosEpia

Copy link
Copy Markdown
Contributor Author

Right. Thanks for the observation. I already changed the base.

@CarlosEpia
CarlosEpia marked this pull request as ready for review May 16, 2025 10:04
@CarlosEpia
CarlosEpia requested a review from ClaraBuettner May 16, 2025 10:05
"wind_onshore": read_costs(costs, "onwind", "VOM"),
"solar": read_costs(costs, "solar", "VOM"),
"run_of_river": 0,
"reservoir": 0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are these values coming from? Could you provide a source?

@CarlosEpia CarlosEpia May 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the last version of PyPSA technology-data and it is still the case, that there are no available VOM data for ror and reservoir. Since it is a common assumption to say that the marginal costs of these technologies are 0 or near 0, I included that value in the scenario_parameters script.

I could add i.e this report which mentioned for hydro generation: "all operations and maintenance costs might be categorized as fixed rather than variable, as the cost of operation is not directly tied to the amount of energy produced"

Source added in 948c901

@CarlosEpia
CarlosEpia requested a review from ClaraBuettner May 23, 2025 12:05
@CarlosEpia
CarlosEpia changed the base branch from release/v2.0.0 to dev June 11, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add VOM for ror and reservoir

3 participants