Skip to content

Features/#1254 pre commit workflow and update versions - #1394

Draft
nesnoj wants to merge 2 commits into
devfrom
features/#1254-pre-commit-workflow-and-update-versions
Draft

Features/#1254 pre commit workflow and update versions#1394
nesnoj wants to merge 2 commits into
devfrom
features/#1254-pre-commit-workflow-and-update-versions

Conversation

@nesnoj

@nesnoj nesnoj commented Mar 9, 2026

Copy link
Copy Markdown
Member

Fixes #1254

Add .github/workflows/pre-commit.yml to enforce code style checks
(trailing whitespace, isort, black, flake8) in CI using the same
rules as local pre-commit hooks.

Also update .pre-commit-config.yaml:

  • Bump pre-commit-hooks v4.4.0 → v4.6.0
  • Fix isort repo URL: timothycrosley/isort → PyCQA/isort, 5.12.0 → 5.13.2
  • Bump black 22.12.0 → 25.1.0
  • Bump flake8 6.0.0 → 7.3.0
  • Fix flake8 language_version: python3.8 → python3.1

📋 Pull Request Guidelines

Please read the Pull Request Guidelines carefully before creating your PR.


🧑‍💻 Contributor Checklist

Before requesting a review, make sure you've completed all of the following:

  • All tests pass locally or via CI
    (for more information on local test, check tox in the Contributing section)
    (CI tests are automatically executed when creating a PR, you can see the results of the checks below)
  • Workflow has run at least once in Test mode
    (optional if no dataset changes are involved)
  • Relevant documentation is updated (API, new features, etc.)
  • Dataset-versions are updated when existing datasets are adjusted.
  • Added a note to CHANGELOG.rst about the changes
  • Added yourself to AUTHORS.rst

Optional:

  • Changes have been tested in Everything mode
  • Extend the checklist for reviewers: Which aspects should be reviewed in particular?
<!-- Example:
Please focus on validating the data handling in file XYZ.
-->

🔍 Reviewer Checklist

During your review, please check the following:

  • Is the code clean, readable, and efficient? Are there any oddities or obvious inefficiencies?
  • Does the code work as expected? (should already be verified by contributor)
  • Do all tests pass? (see CI results)
  • Is the documentation complete and up to date?
  • Is CHANGELOG.rst updated accordingly?
  • Is all necessary metadata complete and correct?
    • If metadata is pending: Is there an appropriate issue filed?

📝 Additional Notes (optional)


💡 Tip: If you add multiple reviewers, clarify who should check what — this saves time and avoids duplicated efforts.

nesnoj added 2 commits March 4, 2026 18:05
  Add .github/workflows/pre-commit.yml to enforce code style checks
  (trailing whitespace, isort, black, flake8) in CI using the same
  rules as local pre-commit hooks.

  Also update .pre-commit-config.yaml:
  - Bump pre-commit-hooks v4.4.0 → v4.6.0
  - Fix isort repo URL: timothycrosley/isort → PyCQA/isort, 5.12.0 → 5.13.2
  - Bump black 22.12.0 → 25.1.0
  - Bump flake8 6.0.0 → 7.3.0
  - Fix flake8 language_version: python3.8 → python3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Pre-commit and PR hooks currently not enforced – formatting issues accumulate

1 participant