Skip to content

Added folder with solidity 0.5.0 compatible validator set contracts#13

Open
Genysys wants to merge 1 commit into
openethereum:masterfrom
Genysys:master
Open

Added folder with solidity 0.5.0 compatible validator set contracts#13
Genysys wants to merge 1 commit into
openethereum:masterfrom
Genysys:master

Conversation

@Genysys

@Genysys Genysys commented Nov 23, 2018

Copy link
Copy Markdown

Fixed breaking changes to validator set contracts. Left old folder as most people are still on 0.4.*

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 96

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 91: 0.0%
Covered Lines: 77
Relevant Lines: 77

💛 - Coveralls

@andresilva andresilva left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 👍 Instead of creating a new folder what do you think about us creating a solidity-0.5.0 branch for this. It would be easier to diff the changes and it would also allow us to update truffle to the latest version which I think uses Solidity v0.5.0, this will make sure that the whole test suite is run against the updated contracts in this PR. We could also add a note in the README (of the master branch) pointing to the branch that supports Solidity v0.5.0.

@Genysys

Genysys commented Nov 28, 2018

Copy link
Copy Markdown
Author

Sounds good happy to make those changes @andresilva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants