Added folder with solidity 0.5.0 compatible validator set contracts#13
Open
Genysys wants to merge 1 commit into
Open
Added folder with solidity 0.5.0 compatible validator set contracts#13Genysys wants to merge 1 commit into
Genysys wants to merge 1 commit into
Conversation
andresilva
requested changes
Nov 28, 2018
andresilva
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! 👍 Instead of creating a new folder what do you think about us creating a solidity-0.5.0 branch for this. It would be easier to diff the changes and it would also allow us to update truffle to the latest version which I think uses Solidity v0.5.0, this will make sure that the whole test suite is run against the updated contracts in this PR. We could also add a note in the README (of the master branch) pointing to the branch that supports Solidity v0.5.0.
Author
|
Sounds good happy to make those changes @andresilva |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed breaking changes to validator set contracts. Left old folder as most people are still on 0.4.*