Ignore pip cache in docker build#259
Open
santuari wants to merge 1 commit into
Open
Conversation
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
9f9f76f to
ae9f436
Compare
Signed-off-by: Michele Santuari <m.santuari@ewo.com>
ae9f436 to
461aaf0
Compare
Author
|
Hi all, I have created this PR that it is very simple. and I guess that no tests are needed. Should I do something more? |
LucasRoesler
approved these changes
Apr 28, 2021
Member
LucasRoesler
left a comment
There was a problem hiding this comment.
This looks good to me and makes a ton of sense
Author
|
Any news on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The pip cache is created during the Docker build and it might occupy around 50MB. The cache is not needed for running the application.
Motivation and Context
Reduce the size of the Docker image
How Has This Been Tested?
I tested by pushing the same function with and without the cache. I also expect that this cannot impact the function behavior.
Types of changes
Impact to existing users
Checklist:
git commit -s