Require domain and hostname at install step#2
Merged
andsnw merged 2 commits intoApr 17, 2026
Conversation
mbokinala
changed the title
mbokinala
force-pushed
the
require-install-domain-hostname
branch
from
96f2532 to
11521b7
Compare
mbokinala
force-pushed
the
require-install-domain-hostname
branch
from
ac681af to
657cddd
Compare
mbokinala
force-pushed
the
require-install-domain-hostname
branch
2 times, most recently
from
0f644dc to
04af0a5
Compare
Typer's rich-formatted error panel (with "Missing option '--public-ip'") prints through a separate rich Console that isn't reliably captured by the CliRunner across runner environments. Verify the failure shape instead: exit code 2 (usage error) plus a Usage line proves the parser rejected the command rather than crashing. Renaming or removing --public-ip is still caught by test_plan_dns_command_outputs_records, which invokes the option on the happy path. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
mbokinala
force-pushed
the
require-install-domain-hostname
branch
from
04af0a5 to
434bcd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require
openmailserver installto take--domainand--hostname, and require--public-ipforplan-dns. This prevents quickstart from silently bootstrapping placeholder domain values and generating misleading DNS guidance.