7903774: make all tests combinations printing nicer and/or configurable by judovana · Pull Request #153 · openjdk/jcstress

judovana · 2024-11-14T16:45:30Z

This is still WIP, but already on row what CODETOOLS-7903774 suggested.

It will be finished once all desired output combinations are included, but already now is doing the usage of listing much more comfortable and code readable.

From:

`TESTS` - as introduced by https://github.com/openjdk/jcstress/pull/149
`COMBINATIONS` - as introduced in https://github.com/openjdk/jcstress/pull/149 verbose mode (thus surpassing the `-v` impact
`ALL_TESTS` - all tests as it was before https://github.com/openjdk/jcstress/pull/149
`COMBINATIONS_GROUPED ` - as suggested in https://github.com/openjdk/jcstress/pull/149#discussion_r1668678910
`COMBINATIONS_JSON` same as combinations, but a valid json
`COMBINATIONS_GROUPS` same as COMBINATIONS_GROUPED only instead of enumeration in each group, only count of members will be printed

TESTS are already implemented as ALL_MATCHING
COMBINATIONS as ALL_MATCHING_COMBINATIONS
ALL_TESTS as ALL

COMBINATIONS_GROUPED, and COMBINATIONS_GROUPS are under development.
The _JSON variants are tobe decided, but ability to JQL it sounds nice.

Suggestion to better names welcomed.

Progress

Change must not contain extraneous whitespace
Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

CODETOOLS-7903774: make all tests combinations printing nicer and/or configurable (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/153/head:pull/153
$ git checkout pull/153

Update a local copy of the PR:
$ git checkout pull/153
$ git pull https://git.openjdk.org/jcstress.git pull/153/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 153

View PR using the GUI difftool:
$ git pr show -t 153

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/153.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2024-11-14T16:46:02Z

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-11-14T16:46:20Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

mlbridge · 2024-11-14T16:49:03Z

Webrevs

judovana · 2024-11-15T17:47:29Z

Implemented
COMBINATIONS_GROUPED and COMBINATIONS_GROUPS (as MATCHING_GROUPS and MATCHING_GROUPS_COUNT) also with its inverted variants

The nice json will maybe need some refactorings. WIP on it, but any feedback appreciated

bridgekeeper · 2024-12-13T20:50:01Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2024-12-14T19:29:23Z

I intend to finish this. Still some feedback if it is even desired, and selected approach is ok, would be nice.

openjdk · 2024-12-23T13:45:45Z

@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

judovana · 2024-12-30T16:50:48Z

hi @shipilev ! This is now feature complete for #149 (comment) what do you think?

bridgekeeper · 2025-01-27T21:00:55Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-02-01T17:29:43Z

...keep live...

judovana · 2025-02-03T12:27:40Z

Just small recap, why this is done - I wanted to split full load of jcstresses, into several HWs. At least 50, so it can finish in reasonable time. This splitting is done by groups - eg https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml#L1128 - to have those groups equally split, information provided by this PR have to be reasonably accessible.

bridgekeeper · 2025-03-03T13:52:38Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-03-03T14:09:43Z

More are on the way!

bridgekeeper · 2025-03-31T20:34:39Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-04-01T10:50:02Z

I still have faith!

bridgekeeper · 2025-04-29T14:11:47Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-04-29T14:28:47Z

loosing faith

judovana · 2025-05-21T12:27:17Z

../live..

bridgekeeper · 2025-06-18T13:37:52Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

instead of misusing verbose switch and thus returned the ability to print allavailable tetest

if true, the key will be written as: "[actor1, actor2], spinLoopStyle: Thread.onSpinWait(), threads: 2, forkId: 0, maxFootprintMB: 64, compileMode: 7, shClass: (PG 0, CG 0), (PG 0, CG 0), strideSize: 256, strideCount: 40, cpuMap: null, [-XX:+UseBiasedLocking, -XX:+StressLCM, -XX:+StressGCM, -XX:+StressIGVN, -XX:+StressCCP, -XX:StressSeed=yyyyyyyy]" otherwise (default), it will be written as ... "actorNames": ["actor1", "actor2"], "spinLoopStyle": "Thread.onSpinWait()", "threads": 2, "forkId": 0, "maxFootprintMB": 64, "compileMode": 7, "shClass": "(PG 0, CG 0), (PG 0, CG 0)", "strideSize": 256, "strideCount": 40, "cpuMap": "null", "jvmArgs": [-XX:+UseBiasedLocking, -XX:+StressLCM, -XX:+StressGCM, -XX:+StressIGVN, -XX:+StressCCP, -XX:StressSeed=yyyyyyyy]" ...

- id can be used both flatten (so equal to plaintext) or properly strcutured for JQ (default) - listing can be redirecd to stderr to use with `jq` directly

openjdk · 2025-06-23T08:42:56Z

@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

bridgekeeper · 2025-07-16T14:40:56Z

@judovana This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

judovana · 2025-07-16T14:45:47Z

/open

judovana · 2025-07-16T14:45:51Z

faith restored

judovana · 2025-07-16T14:47:18Z

/open

openjdk · 2025-07-16T14:47:20Z

@judovana This pull request is now open

openjdk · 2025-07-16T14:47:30Z

@judovana This pull request is already open

bridgekeeper · 2025-08-13T21:18:24Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-08-14T11:02:46Z

Is there hope?

bridgekeeper · 2025-09-12T00:30:43Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-09-12T10:05:30Z

Loosing the faith...

bridgekeeper · 2025-10-10T15:17:41Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-10-13T07:53:09Z

Loosing the faith...

bridgekeeper · 2025-11-10T20:54:30Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-11-11T08:20:18Z

keep_alive

bridgekeeper · 2025-12-10T13:17:29Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-12-22T17:19:53Z

Need for this still valid

judovana · 2026-01-08T11:57:18Z

keep alive

bridgekeeper · 2026-02-05T20:33:41Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2026-02-06T11:22:35Z

Once upon a midnight dreary, while I pondered, weak and weary,
Over many a quaint and curious volume of forgotten lore—
    While I nodded, nearly napping, suddenly there came a tapping,
As of some one gently rapping, rapping at my chamber door.
“’Tis some visitor,” I muttered, “tapping at my chamber door—
            Only this and nothing more.”

bridgekeeper · 2026-03-06T13:13:06Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2026-03-16T16:18:37Z

      Ah, distinctly I remember it was in the bleak December,
And each separate dying ember wrought its ghost upon the floor.
   Eagerly I wished the morrow;- vainly I had sought to borrow
From my books surcease of sorrow- sorrow for the lost Lenore-
For the rare and radiant maiden whom the angels name Lenore-
                 Nameless here for evermore.

bridgekeeper · 2026-04-13T17:44:31Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2026-04-28T08:01:07Z

 And the silken, sad, uncertain rustling of each purple curtain
Thrilled me—filled me with fantastic terrors never felt before;
    So that now, to still the beating of my heart, I stood repeating
    “’Tis some visitor entreating entrance at my chamber door—
Some late visitor entreating entrance at my chamber door;—
            This it is and nothing more.”

judovana changed the title ~~CODETOOLS-7903774~~ CODETOOLS-7903774 make all tests combinations printing nicer and/or configurable Nov 14, 2024

openjdk Bot changed the title ~~CODETOOLS-7903774 make all tests combinations printing nicer and/or configurable~~ 7903774: make all tests combinations printing nicer and/or configurable Nov 14, 2024

openjdk Bot added the rfr Pull request is ready for review label Nov 14, 2024

judovana marked this pull request as draft November 14, 2024 18:06

openjdk Bot removed the rfr Pull request is ready for review label Nov 14, 2024

judovana marked this pull request as ready for review November 15, 2024 17:46

openjdk Bot added the rfr Pull request is ready for review label Nov 15, 2024

judovana force-pushed the betterLsiting branch from 0219ab9 to 60bbb3e Compare December 23, 2024 13:45

judovana added 3 commits June 23, 2025 10:34

refactored listTests() to its own class

83ba443

Refactored lsiting so it takes proper argument

3713037

instead of misusing verbose switch and thus returned the ability to print allavailable tetest

implemented MATCHING_(INVERTED)GROUPS(_COUNT)

276ec8b

judovana added 3 commits June 23, 2025 10:34

ALL now corectly return all tests

fc23a33

Implemented proper json listings

6f327f7

- id can be used both flatten (so equal to plaintext) or properly strcutured for JQ (default) - listing can be redirecd to stderr to use with `jq` directly

judovana force-pushed the betterLsiting branch from b8d0209 to 6f327f7 Compare June 23, 2025 08:42

bridgekeeper Bot closed this Jul 16, 2025

openjdk Bot reopened this Jul 16, 2025

Conversation

judovana commented Nov 14, 2024 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewing

Uh oh!

bridgekeeper Bot commented Nov 14, 2024

Uh oh!

openjdk Bot commented Nov 14, 2024

Uh oh!

mlbridge Bot commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

judovana commented Nov 15, 2024

Uh oh!

bridgekeeper Bot commented Dec 13, 2024

Uh oh!

judovana commented Dec 14, 2024

Uh oh!

openjdk Bot commented Dec 23, 2024

Uh oh!

judovana commented Dec 30, 2024

Uh oh!

bridgekeeper Bot commented Jan 27, 2025

Uh oh!

judovana commented Feb 1, 2025

Uh oh!

judovana commented Feb 3, 2025

Uh oh!

bridgekeeper Bot commented Mar 3, 2025

Uh oh!

judovana commented Mar 3, 2025

Uh oh!

bridgekeeper Bot commented Mar 31, 2025

Uh oh!

judovana commented Apr 1, 2025

Uh oh!

bridgekeeper Bot commented Apr 29, 2025

Uh oh!

judovana commented Apr 29, 2025

Uh oh!

judovana commented May 21, 2025

Uh oh!

bridgekeeper Bot commented Jun 18, 2025

Uh oh!

openjdk Bot commented Jun 23, 2025

Uh oh!

bridgekeeper Bot commented Jul 16, 2025

Uh oh!

judovana commented Jul 16, 2025

Uh oh!

judovana commented Jul 16, 2025

Uh oh!

judovana commented Jul 16, 2025

Uh oh!

openjdk Bot commented Jul 16, 2025

Uh oh!

openjdk Bot commented Jul 16, 2025

Uh oh!

bridgekeeper Bot commented Aug 13, 2025

Uh oh!

judovana commented Aug 14, 2025

Uh oh!

bridgekeeper Bot commented Sep 12, 2025

Uh oh!

judovana commented Sep 12, 2025

Uh oh!

bridgekeeper Bot commented Oct 10, 2025

Uh oh!

judovana commented Oct 13, 2025

Uh oh!

bridgekeeper Bot commented Nov 10, 2025

Uh oh!

judovana commented Nov 11, 2025

Uh oh!

bridgekeeper Bot commented Dec 10, 2025

Uh oh!

judovana commented Dec 22, 2025

judovana commented Nov 14, 2024 •

edited by openjdk Bot

Loading

mlbridge Bot commented Nov 14, 2024 •

edited

Loading