8387291: XSLT transformation fails on accented characters when output is set to HTML instead of XML#31689
Open
shruacha1234 wants to merge 1 commit into
Open
8387291: XSLT transformation fails on accented characters when output is set to HTML instead of XML#31689shruacha1234 wants to merge 1 commit into
shruacha1234 wants to merge 1 commit into
Conversation
… is set to HTML instead of XML Signed-off-by: Shruthi <Shruthi.Shruthi1@ibm.com>
|
👋 Welcome back sacharya! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@shruacha1234 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When XSLT output method is html, characters supported by the target encoding were serialized as HTML entity references (for example, é as eacute;). This caused failures when the generated output was later processed as XML.
Solution:
Update HTML serializer to write characters directly when they are supported by the configured encoding, and retain existing entity escaping behavior for unsupported characters.
Testing:
Verified XSLT transformation with accented characters and confirmed generated output can be parsed successfully without XML parsing failures.
Performed Tier1 and Tier2 tests in Linux with and without the fix. No regression found
The bug report for the same: https://bugs.openjdk.org/browse/JDK-8387291
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31689/head:pull/31689$ git checkout pull/31689Update a local copy of the PR:
$ git checkout pull/31689$ git pull https://git.openjdk.org/jdk.git pull/31689/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31689View PR using the GUI difftool:
$ git pr show -t 31689Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31689.diff